Skip to content

ARM: cpuidle: code consolidation

Daniel Lezcano linux-arm-kernel linux-pm 1 version New

Get series with b4
b4 am [email protected]

Versions newest first

  1. v1 Latest15 patches 0 repliesNew

Patches in v1 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/15timer: move enum definition out of ifdef sectioninclude/linux/clockchips.h+11 -111 reply
1/15timer: move enum definition out of ifdef section+0 -00 replies
2/15cpuidle: initialize the broadcast timer frameworkdrivers/cpuidle/driver.c include/linux/cpuidle.h+35 -21 reply
3/15cpuidle: ux500: remove timer broadcast initializationarch/arm/mach-ux500/cpuidle.c+0 -181 reply
4/15cpuidle: OMAP4: remove timer broadcast initializationarch/arm/mach-omap2/cpuidle44xx.c+0 -141 reply
5/15cpuidle: imx6: remove timer broadcast initializationarch/arm/mach-imx/cpuidle-imx6q.c+0 -152 replies
5/15cpuidle: imx6: remove timer broadcast initialization+0 -01 reply
5/15cpuidle: imx6: remove timer broadcast initialization+0 -01 reply
6/15ARM: cpuidle: remove useless declarationarch/arm/include/asm/cpuidle.h+1 -60 replies
7/15ARM: cpuidle: add init/exit routinearch/arm/include/asm/cpuidle.h arch/arm/kernel/cpuidle.c+60 -11 reply
7/15ARM: cpuidle: add init/exit routine+0 -02 replies
7/15ARM: cpuidle: add init/exit routine+0 -02 replies
7/15ARM: cpuidle: add init/exit routine+0 -00 replies
7/15ARM: cpuidle: add init/exit routine+0 -01 reply
7/15ARM: cpuidle: add init/exit routine+0 -00 replies
8/15ARM: ux500: cpuidle: use init/exit common routinearch/arm/mach-ux500/cpuidle.c+1 -311 reply
9/15ARM: at91: cpuidle: use init/exit common routinearch/arm/mach-at91/cpuidle.c+2 -151 reply
10/15ARM: OMAP3: cpuidle: use init/exit common routinearch/arm/mach-omap2/cpuidle34xx.c+2 -160 replies
11/15ARM: s3c64xx: cpuidle: use init/exit common routinearch/arm/mach-s3c64xx/cpuidle.c+2 -130 replies
12/15ARM: tegra1: cpuidle: use init/exit common routinearch/arm/mach-tegra/cpuidle-tegra114.c+1 -260 replies
13/15ARM: shmobile: pm: fix init sectionsarch/arm/mach-shmobile/cpuidle.c arch/arm/mach-shmobile/pm-sh7372.c+4 -41 reply
14/15ARM: shmobile: cpuidle: remove useless WFI functionarch/arm/mach-shmobile/cpuidle.c+0 -81 reply
15/15ARM: shmobile: cpuidle: use init/exit common routinearch/arm/mach-shmobile/cpuidle.c+1 -91 reply

Reviews trailers per patch

10 of 23 patches have a Reviewed-by or Acked-by.

PatchSantosh ShilimkarNicolas FerreShawn GuoSimon HormanLinus Walleij
1/15
1/15
2/15
3/15A-b
4/15A-b
5/15A-b A-b
5/15A-b A-b
5/15A-b A-b
6/15
7/15
7/15
7/15
7/15
7/15
7/15
8/15A-b
9/15A-b
10/15
11/15
12/15
13/15A-b
14/15A-b
15/15A-b

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes. Scroll the table sideways for all 5 reviewers.

Read the v1 thread

Cover letter [PATCH 00/15] ARM: cpuidle: code consolidation

The flag CPUIDLE_FLAG_TIMER_STOP has been introduced in the commit 89878baa73f0f1c679355006bd8632e5d78f96c2.

The flag tells the cpuidle framework the local timer will stop in the idle state.

It is now easy to know if the cpuidle driver will use or not the broadcast timer by looking at the different states for this flag and then setup the broadcast timer consequently.

When we remove the timer initialization duplicated code in the different drivers, we have most of the drivers with the same init function. This init function is changed to be generic and moved in the ARM cpuidle driver and used from the drivers. That cleanups code and removes a lot of annoying duplicated code.

There is still some modification in OMAP4, tegra2, tegra3 and imx, especially around the coupled idle states, but we are more and more closer to a common squeleton for all the ARM drivers.

Daniel Lezcano (15):
timer: move enum definition out of ifdef section
cpuidle: initialize the broadcast timer framework
cpuidle: ux500: remove timer broadcast initialization
cpuidle: OMAP4: remove timer broadcast initialization
cpuidle: imx6: remove timer broadcast initialization
ARM: cpuidle: remove useless declaration
ARM: cpuidle: add init/exit routine
ARM: ux500: cpuidle: use init/exit common routine
ARM: at91: cpuidle: use init/exit common routine
ARM: OMAP3: cpuidle: use init/exit common routine
ARM: s3c64xx: cpuidle: use init/exit common routine
ARM: tegra1: cpuidle: use init/exit common routine
ARM: shmobile: pm: fix init sections
ARM: shmobile: cpuidle: remove useless WFI function
ARM: shmobile: cpuidle: use init/exit common routine

 arch/arm/include/asm/cpuidle.h         |   11 +++---
 arch/arm/kernel/cpuidle.c              |   57 +++++++++++++++++++++++++++++++-
 arch/arm/mach-at91/cpuidle.c           |   17 ++--------
 arch/arm/mach-imx/cpuidle-imx6q.c      |   15 ---------
 arch/arm/mach-omap2/cpuidle34xx.c      |   18 ++--------
 arch/arm/mach-omap2/cpuidle44xx.c      |   14 --------
 arch/arm/mach-s3c64xx/cpuidle.c        |   15 ++-------
 arch/arm/mach-shmobile/cpuidle.c       |   22 ++----------
 arch/arm/mach-shmobile/pm-sh7372.c     |    4 +--
 arch/arm/mach-tegra/cpuidle-tegra114.c |   27 +--------------
 arch/arm/mach-ux500/cpuidle.c          |   50 +---------------------------
 drivers/cpuidle/driver.c               |   35 ++++++++++++++++++--
 include/linux/clockchips.h             |   22 ++++++------
 include/linux/cpuidle.h                |    2 ++
 14 files changed, 120 insertions(+), 189 deletions(-)
Signature · 1 line
1.7.9.5