Skip to content

target-i386: add PCLMULQDQ and AES-NI instructions

Aurelien Jarno qemu-devel 3 versions – In review

Get series with b4
b4 am [email protected]

Versions newest first · linked by author and title

  1. v4 Latest7 patches 3 repliesIn review
  2. v23 patches 2 repliesSuperseded
  3. v13 patches 3 repliesSuperseded

Changes in v4 from the cover letter

- Update dissassembler code to support these instructions.

Patches in v4 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/7disas/i386.c: disassemble pclmulqdq instructiondisas/i386.c+11 -20 replies
2/7target-i386: add pclmulqdq instructiontarget-i386/cpu.c target-i386/ops_sse.h target-i386/ops_sse_header.h +1 more+41 -100 replies
3/7target-i386: enable PCLMULQDQ on Westmere CPUtarget-i386/cpu.c+1 -11 reply
4/7disas/i386.c: disassemble aes-ni instructionsdisas/i386.c+61 -60 replies
5/7aes: move aes.h from include/block to include/qemublock/qcow.c block/qcow2.c block/qcow2.h +3 more+30 -301 reply
6/7aes: make Td[0-5] and Te[0-5] tables non staticinclude/qemu/aes.h util/aes.c+271 -2520 replies
7/7target-i386: add AES-NI instructionsdisas/i386.c target-i386/cpu.c target-i386/fpu_helper.c +3 more+106 -50 replies

Reviews trailers per patch

5 of 7 patches have a Reviewed-by or Acked-by of their own; the series has one for all of them.

PatchRichard HendersonEdgar E. IglesiasStefan Hajnoczi
SeriesR-b
1/7
2/7R-b R-b
3/7R-b R-b
4/7
5/7R-b R-b R-b
6/7R-b R-b
7/7R-b R-b

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes. Scroll the table sideways for all 3 reviewers.

Read the v4 thread

Cover letter [Qemu-devel] [PATCH v4 0/7] target-i386: add PCLMULQDQ and AES-NI instructions

This patch series adds the PCLMULQDQ and AES-NI instructions to the x86 emulation. Along with the SSE4.1 and SSE4.2 series, this brings the instructions emulation to the level of a Westmere CPU.

It has been tested with the valgrind testsuite and with the kernel autotest.

Changes v1 -> v2:
- Patch 3: Declare all constant tables as static.

Changes v2 -> v3:
- Use constant tables from aes.c.
- Fix AES instructions when source and destination registers are the same.

Changes v3 -> v4:
- Update dissassembler code to support these instructions.

Aurelien Jarno (7):
disas/i386.c: disassemble pclmulqdq instruction
target-i386: add pclmulqdq instruction
target-i386: enable PCLMULQDQ on Westmere CPU disas/i386.c: disassemble aes-ni instructions
aes: move aes.h from include/block to include/qemu
aes: make Td[0-5] and Te[0-5] tables non static
target-i386: add AES-NI instructions

 block/qcow.c                 |    2 +-
 block/qcow2.c                |    2 +-
 block/qcow2.h                |    2 +-
 disas/i386.c                 |   84 ++++++-
 include/block/aes.h          |   26 ---
 include/qemu/aes.h           |   45 ++++
 target-i386/cpu.c            |   19 +-
 target-i386/fpu_helper.c     |    1 +
 target-i386/ops_sse.h        |  111 +++++++++
 target-i386/ops_sse_header.h |   11 +
 target-i386/translate.c      |   10 +
 util/aes.c                   |  506 +++++++++++++++++++++---------------------
 12 files changed, 517 insertions(+), 302 deletions(-)
 delete mode 100644 include/block/aes.h
 create mode 100644 include/qemu/aes.h
Signature · 1 line
1.7.10.4