Skip to content

x86/hvm: RTC periodic timer adjustments

Tim Deegan xen-devel 2 versions In review

Get series with b4
b4 am [email protected]

Versions newest first · linked by author and title

  1. v2 Latest4 patches 3 repliesIn review
  2. v14 patches 15 repliesSuperseded

Changes in v2 from the cover letter

- moved the irq logic patch to the end of the queue so the others can be applied independently
- in the irq logic, keep the strobing behaviour as before
- store period_code instead of period and pt_active

Patches in v2 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/4x86/hvm: Run the RTC periodic timer on a consistent time series.xen/arch/x86/hvm/rtc.c xen/include/asm-x86/hvm/vpt.h+6 -30 replies
2/4x86/hvm: Avoid needlessly resetting the periodic timer.xen/arch/x86/hvm/rtc.c xen/include/asm-x86/hvm/vpt.h+19 -90 replies
3/4x86/hvm: Let the guest miss a few ticks before resetting the timer.xen/arch/x86/hvm/rtc.c xen/include/asm-x86/hvm/vpt.h+10 -60 replies
4/4x86/hvm: Centralize and simplify the RTC IRQ logic.xen/arch/x86/hvm/rtc.c+20 -200 replies

Reviews trailers per patch

1 of 4 patches has a Reviewed-by or Acked-by of their own; the series has one for all of them.

PatchKeir FraserJan Beulich
SeriesA-b A-b
1/4A-b
2/4
3/4
4/4

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes.

Read the v2 thread

Cover letter [PATCH 0/4 v2] x86/hvm: RTC periodic timer adjustments

With these four patches, the time drift that was happening on Windows XP guests goes away, at least in my testing. 3/4 is probably the most important (with the other three, I still see slow drift), but the others all seem like a good idea to me.

Changes since v1:
- moved the irq logic patch to the end of the queue so the others can be applied independently
- in the irq logic, keep the strobing behaviour as before
- store period_code instead of period and pt_active

Cheers,

Tim.