nf_tables: atomic transactional updates (v2)
Get series with b4
b4 am [email protected]Versions newest first
- v1 Latest2 patches 1 replyIn review
Patches in v1 No applies recorded yet
| # | Subject and files | Size | Replies | Applied |
|---|---|---|---|---|
| 1/2 | netfilter: nf_tables: rework atomic transaction updatesinclude/ include/ include/ +1 more | +174 | 1 reply | |
| 2/2 | netfilter: nf_tables: set NLM_F_DUMP_INTR if dump is invalidinclude/ net/ | +6 | 0 replies |
Reviews trailers per patch
No Reviewed-by, Acked-by or Tested-by trailers for v1 yet.
Cover letter [PATCH 0/2] nf_tables: atomic transactional updates (v2)
From: Pablo Neira Ayuso <[email protected]>
Hi,
This patchset comes after this patch:
http://patchwork.ozlabs.org/patch/224196/
and results from discussion with Tomasz and Patrick, the summary of changes for the first patch are:
* Get rid of the extra struct list_head per rule as discussed with Patrick McHardy. With this patch, a temporary object is allocated to store the rule update information.
* A new begin operation to explicitly enter the transaction mode, and remove the COMMIT flag per rule, as suggested by Tomasz.
* The commit and abort loops have been also simplified from ideas extracted after discusion with Tomasz Bursztyka. Basically, there is a single list per net namespace that contains pending rule updates.
* The transaction list is now owned by the netlink socket portid that adds the first rule that waits to be committed. If another process wants to perform some rule-set update, it hits -EBUSY.
* Pending updates, if not committed, are destroyed when the process explicit aborts or finishes its execution.
The second patch uses NLM_F_DUMP_INTR if the dump in interrupted by an update.
Comments welcome.
Pablo Neira Ayuso (2):
netfilter: nf_tables: rework atomic transaction updates
netfilter: nf_tables: set NLM_F_DUMP_INTR if dump is invalid
include/net/netfilter/nf_tables.h | 21 ++- include/net/netns/nftables.h | 4 +- include/uapi/linux/netfilter/nf_tables.h | 7 +- net/netfilter/nf_tables_api.c | 242 +++++++++++++++++++----------- 4 files changed, 179 insertions(+), 95 deletions(-)
Signature · 1 line
1.7.10.4