Skip to content

target-i386: add PCLMULQDQ and AES-NI instructions

Aurelien Jarno qemu-devel 1 version In review

Get series with b4
b4 am [email protected]

Versions newest first

  1. v1 Latest5 patches 2 repliesIn review

Changes v1 -> v2 from the cover letter

- Patch 3: Declare all constant tables as static

Patches in v1 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/5target-i386: add pclmulqdq instructiontarget-i386/cpu.c target-i386/ops_sse.h target-i386/ops_sse_header.h +1 more+41 -100 replies
2/5target-i386: enable PCLMULQDQ on Westmere CPUtarget-i386/cpu.c+1 -10 replies
3/5aes: move aes.h from include/block to include/qemublock/qcow.c block/qcow2.c block/qcow2.h +3 more+30 -300 replies
4/5aes: make Td[0-5] and Te[0-5] tables non staticinclude/qemu/aes.h util/aes.c+271 -2520 replies
5/5target-i386: add AES-NI instructionstarget-i386/cpu.c target-i386/fpu_helper.c target-i386/ops_sse.h +2 more+104 -30 replies

Reviews trailers per patch

2 of 5 patches have a Reviewed-by or Acked-by of their own; the series has one for all of them.

PatchRichard HendersonEdgar E. Iglesias
SeriesR-b R-b
1/5R-b
2/5R-b
3/5
4/5
5/5

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes.

Read the v1 thread

Cover letter [Qemu-devel] [PATCH 0/5] target-i386: add PCLMULQDQ and AES-NI instructions

This patch series adds the PCLMULQDQ and AES-NI instructions to the x86 emulation. Along with the SSE4.1 and SSE4.2 series, this brings the instructions emulation to the level of a Westmere CPU.

It has been tested with the valgrind testsuite and with the kernel autotest.

Changes v1 -> v2:
- Patch 3: Declare all constant tables as static

Changes v2 -> v3:
- Use constant tables from aes.c.
- Fix AES instructions when source and destination registers are the same.

Aurelien Jarno (5):
target-i386: add pclmulqdq instruction
target-i386: enable PCLMULQDQ on Westmere CPU
aes: move aes.h from include/block to include/qemu
aes: make Td[0-5] and Te[0-5] tables non static
target-i386: add AES-NI instructions

 block/qcow.c                 |    2 +-
 block/qcow2.c                |    2 +-
 block/qcow2.h                |    2 +-
 include/block/aes.h          |   26 ---
 include/qemu/aes.h           |   45 ++++
 target-i386/cpu.c            |   19 +-
 target-i386/fpu_helper.c     |    1 +
 target-i386/ops_sse.h        |  111 +++++++++
 target-i386/ops_sse_header.h |   11 +
 target-i386/translate.c      |   10 +
 util/aes.c                   |  506 +++++++++++++++++++++---------------------
 11 files changed, 443 insertions(+), 292 deletions(-)
 delete mode 100644 include/block/aes.h
 create mode 100644 include/qemu/aes.h
Signature · 1 line
1.7.10.4