Skip to content

UAC2: Automatic clock switching

Eldad Zack alsa-devel 2 versions – Applied

Status from this message: Applied all 10 patches now. Thanks.

Get series with b4
b4 am [email protected]

Versions newest first · linked by author and title

  1. v2 Latest10 patches 1 replyApplied
  2. v110 patches 13 repliesSuperseded

Changes from the cover letter

* Fixed formatting
* (#5) Fixed type cast: u32 -> __l32
* (#6) Added rational to commit message
* (#7) Fixed assignment of int to unsigned char, return error code if encountered
* (#8) Fixed the parameter name, annotated the default value
* (#10) Avoid second read of frequency for read-only clocks

Patches in v2 Applied

#Subject and filesSizeRepliesApplied
1/10ALSA: usb-audio: convert list_for_each to entry variantsound/usb/card.c sound/usb/endpoint.c sound/usb/midi.c +3 more+21 -410 replies
2/10ALSA: usb-audio: neaten MODULE_DEVICE_TABLE placementsound/usb/card.c+1 -20 replies
3/10ALSA: usb-audio: neaten EXPORT_SYMBOLS placementsound/usb/midi.c+3 -40 replies
4/10ALSA: usb-audio: spelling correctionsound/usb/endpoint.c sound/usb/endpoint.h sound/usb/pcm.c+9 -90 replies
5/10ALSA: usb-audio: use endianness macrossound/usb/clock.c+6 -90 replies
6/10ALSA: usb-audio: UAC2: do clock validity check earliersound/usb/clock.c sound/usb/clock.h sound/usb/format.c+21 -180 replies
7/10ALSA: usb-audio: UAC2: try to find and switch to valid clocksound/usb/clock.c+66 -30 replies
8/10ALSA: usb-audio: UAC2: auto clock selection module paramsound/usb/card.c sound/usb/clock.c sound/usb/usbaudio.h+6 -10 replies
9/10ALSA: usb-audio: show err in set_sample_rate_v2 debugsound/usb/clock.c+4 -40 replies
10/10ALSA: usb-audio: UAC2: support read-only freq controlsound/usb/clock.c+26 -110 replies

Reviews trailers per patch

No Reviewed-by, Acked-by or Tested-by trailers for v2 yet.

Read the v2 thread

Cover letter [PATCHv2 00/10] UAC2: Automatic clock switching

This is version 2 of the automatic clock switching.
v1: http://mailman.alsa-project.org/pipermail/alsa-devel/2013-March/060734.html

No patches added or removed.
Rebased patches with "ALSA: usb: Work around CM6631 sample rate change bug", commit 690a863ff03d9a29ace2b752b8f802fba78a842f .

Clemens, Takashi and Torstein, thank you very much for reviewing and providing comments!

Changes:
* Fixed formatting
* (#5) Fixed type cast: u32 -> __l32
* (#6) Added rational to commit message
* (#7) Fixed assignment of int to unsigned char, return error code if encountered
* (#8) Fixed the parameter name, annotated the default value
* (#10) Avoid second read of frequency for read-only clocks

Tested with Takashi's for-next.
Applies against Takashi's for-next HEAD efc33ce197e4b6aaddf1eb2ba6293f51daf3c283 .

Cheers,

Eldad Zack (10):
ALSA: usb-audio: convert list_for_each to entry variant
ALSA: usb-audio: neaten MODULE_DEVICE_TABLE placement
ALSA: usb-audio: neaten EXPORT_SYMBOLS placement
ALSA: usb-audio: spelling correction
ALSA: usb-audio: use endianness macros
ALSA: usb-audio: UAC2: do clock validity check earlier
ALSA: usb-audio: UAC2: try to find and switch to valid clock
ALSA: usb-audio: UAC2: auto clock selection module param
ALSA: usb-audio: show err in set_sample_rate_v2 debug
ALSA: usb-audio: UAC2: support read-only freq control

 sound/usb/card.c     |  11 ++--
 sound/usb/clock.c    | 153 ++++++++++++++++++++++++++++++++++++++-------------
 sound/usb/clock.h    |   3 +-
 sound/usb/endpoint.c |  18 +++---
 sound/usb/endpoint.h |   2 +-
 sound/usb/format.c   |   2 +-
 sound/usb/midi.c     |  12 ++--
 sound/usb/pcm.c      |  32 ++++-------
 sound/usb/proc.c     |   7 +--
 sound/usb/stream.c   |  12 ++--
 sound/usb/usbaudio.h |   1 +
 11 files changed, 157 insertions(+), 96 deletions(-)
Signature · 1 line
1.8.1.5