Skip to content

Rework HIDP Session Management

David Herrmann linux-bluetooth 3 versions – In review

Get series with b4
b4 am [email protected]

Versions newest first · linked by author and title

  1. v4 Latest16 patches 2 repliesIn review
  2. v318 patches 6 repliesSuperseded
  3. v218 patches 5 repliesSuperseded

Patches in v4 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/16Bluetooth: rename hci_conn_put to hci_conn_dropinclude/net/bluetooth/hci_core.h net/bluetooth/hci_conn.c net/bluetooth/hci_event.c +4 more+32 -321 reply
2/16Bluetooth: remove unneeded hci_conn_hold/put_device()include/net/bluetooth/hci_core.h net/bluetooth/hci_conn.c net/bluetooth/hci_event.c +1 more+4 -411 reply
3/16Bluetooth: introduce hci_conn ref-countinginclude/net/bluetooth/hci_core.h net/bluetooth/hci_conn.c net/bluetooth/hci_sysfs.c+32 -30 replies
4/16Bluetooth: hidp: remove unused session->state fieldnet/bluetooth/hidp/core.c net/bluetooth/hidp/hidp.h+2 -40 replies
5/16Bluetooth: hidp: test "terminate" before sleepingnet/bluetooth/hidp/core.c+8 -40 replies
6/16Bluetooth: allow constant arguments for bacmp()/bacpy()include/net/bluetooth/bluetooth.h+2 -20 replies
7/16Bluetooth: hidp: move hidp_schedule() to core.cnet/bluetooth/hidp/core.c net/bluetooth/hidp/hidp.h+9 -90 replies
8/16Bluetooth: l2cap: introduce l2cap_conn ref-countinginclude/net/bluetooth/l2cap.h net/bluetooth/l2cap_core.c+28 -10 replies
9/16Bluetooth: l2cap: add l2cap_user sub-modulesinclude/net/bluetooth/l2cap.h net/bluetooth/l2cap_core.c+96 -00 replies
10/16Bluetooth: hidp: add new session-management helpersnet/bluetooth/hidp/core.c net/bluetooth/hidp/hidp.h+583 -250 replies
11/16Bluetooth: hidp: remove old session-managementnet/bluetooth/hidp/core.c net/bluetooth/hidp/hidp.h net/bluetooth/hidp/sock.c+18 -3480 replies
12/16Bluetooth: hidp: handle kernel_sendmsg() errors correctlynet/bluetooth/hidp/core.c+14 -20 replies
13/16Bluetooth: hidp: merge hidp_process_{ctrl,intr}_transmit()net/bluetooth/hidp/core.c+11 -290 replies
14/16Bluetooth: hidp: merge 'send' functions into hidp_send_message()net/bluetooth/hidp/core.c+60 -960 replies
15/16Bluetooth: hidp: don't send boot-protocol messages as HID-reportsnet/bluetooth/hidp/core.c+5 -190 replies
16/16Bluetooth: hidp: fix sending output reports on intr channelnet/bluetooth/hidp/core.c+5 -70 replies

Reviews trailers per patch

All 16 patches have a Reviewed-by or Acked-by.

PatchMarcel Holtmann
1/16A-b
2/16A-b
3/16A-b
4/16A-b
5/16A-b
6/16A-b
7/16A-b
8/16A-b
9/16A-b
10/16A-b
11/16A-b
12/16A-b
13/16A-b
14/16A-b
15/16A-b
16/16A-b

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes.

Read the v4 thread

Cover letter [PATCH v4 00/16] Rework HIDP Session Management

Hi

No changes from v3, but rebased onto bluetooth-next/master. Sorry, I forgot that on the previous series.
I tested it with bluetooth-next and everything works great. Only conflicts were some unrelated HCI core-fixes.

Regards
David

David Herrmann (16):
Bluetooth: rename hci_conn_put to hci_conn_drop
Bluetooth: remove unneeded hci_conn_hold/put_device()
Bluetooth: introduce hci_conn ref-counting
Bluetooth: hidp: remove unused session->state field
Bluetooth: hidp: test "terminate" before sleeping
Bluetooth: allow constant arguments for bacmp()/bacpy()
Bluetooth: hidp: move hidp_schedule() to core.c
Bluetooth: l2cap: introduce l2cap_conn ref-counting
Bluetooth: l2cap: add l2cap_user sub-modules
Bluetooth: hidp: add new session-management helpers
Bluetooth: hidp: remove old session-management
Bluetooth: hidp: handle kernel_sendmsg() errors correctly
Bluetooth: hidp: merge hidp_process_{ctrl,intr}_transmit()
Bluetooth: hidp: merge 'send' functions into hidp_send_message()
Bluetooth: hidp: don't send boot-protocol messages as HID-reports
Bluetooth: hidp: fix sending output reports on intr channel

 include/net/bluetooth/bluetooth.h |   4 +-
 include/net/bluetooth/hci_core.h  |  35 +-
 include/net/bluetooth/l2cap.h     |  14 +
 net/bluetooth/hci_conn.c          |  26 +-
 net/bluetooth/hci_event.c         |  40 +-
 net/bluetooth/hci_sysfs.c         |   1 -
 net/bluetooth/hidp/core.c         | 994 ++++++++++++++++++++++----------------
 net/bluetooth/hidp/hidp.h         |  67 ++-
 net/bluetooth/hidp/sock.c         |  21 +-
 net/bluetooth/l2cap_core.c        | 117 ++++-
 net/bluetooth/mgmt.c              |   6 +-
 net/bluetooth/sco.c               |   6 +-
 net/bluetooth/smp.c               |   2 +-
 13 files changed, 810 insertions(+), 523 deletions(-)
Signature · 1 line
1.8.2