Skip to content

xfs: metadata CRCs, fourth version

Dave Chinner linux-xfs 1 version In review

Get series with b4
b4 am [email protected]

Versions newest first

  1. v1 Latest22 patches 26 repliesIn review

Patches in v1 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/22xfs: increase hexdump output in xfs_corruption_errorfs/xfs/xfs_error.c+1 -10 replies
2/22xfs: add support for large btree blocksfs/xfs/xfs_alloc_btree.c fs/xfs/xfs_alloc_btree.h fs/xfs/xfs_attr_leaf.c +14 more+645 -2090 replies
3/22xfs: add CRC checks to the AGFfs/xfs/xfs_ag.h fs/xfs/xfs_alloc.c fs/xfs/xfs_buf_item.h +2 more+91 -270 replies
4/22xfs: add CRC checks to the AGFLfs/xfs/xfs_ag.h fs/xfs/xfs_alloc.c fs/xfs/xfs_buf_item.h +2 more+119 -440 replies
5/22xfs: add CRC checks to the AGIfs/xfs/xfs_ag.h fs/xfs/xfs_buf_item.h fs/xfs/xfs_fsops.c +2 more+65 -150 replies
6/22xfs: add CRC checks for quota blocksfs/xfs/xfs_dquot.c fs/xfs/xfs_log_recover.c fs/xfs/xfs_qm.c +2 more+141 -170 replies
7/22xfs: add version 3 inode format with CRCsfs/xfs/xfs_buf_item.h fs/xfs/xfs_dinode.h fs/xfs/xfs_ialloc.c +5 more+254 -770 replies
8/22xfs: split out symlink code into it's own file.fs/xfs/Makefile fs/xfs/xfs_bmap.c fs/xfs/xfs_symlink.c +2 more+578 -4930 replies
9/22xfs: add CRC checks to remote symlinksfs/xfs/xfs_buf_item.h fs/xfs/xfs_log_recover.c fs/xfs/xfs_symlink.c +1 more+283 -430 replies
10/22xfs: add CRC checks to block format directory blocksfs/xfs/xfs_dir2_block.c fs/xfs/xfs_dir2_data.c fs/xfs/xfs_dir2_format.h +4 more+344 -1050 replies
11/22xfs: add CRC checking to dir2 free blocksfs/xfs/xfs_dir2_format.h fs/xfs/xfs_dir2_leaf.c fs/xfs/xfs_dir2_node.c+382 -1620 replies
12/22xfs: add CRC checking to dir2 data blocksfs/xfs/xfs_dir2_block.c fs/xfs/xfs_dir2_data.c fs/xfs/xfs_dir2_format.h +4 more+162 -1050 replies
13/22xfs: add CRC checking to dir2 leaf blocksfs/xfs/xfs_da_btree.c fs/xfs/xfs_da_btree.h fs/xfs/xfs_dir2_block.c +4 more+918 -5194 replies
14/22xfs: shortform directory offsets change for dir3 formatfs/xfs/xfs_dir2_format.h fs/xfs/xfs_dir2_sf.c+19 -161 reply
15/22xfs: add CRCs to dir2/da node blocksfs/xfs/xfs_attr.c fs/xfs/xfs_attr_leaf.c fs/xfs/xfs_bmap.c +4 more+972 -6203 replies
16/22xfs: add CRCs to attr leaf blocksfs/xfs/xfs_attr.c fs/xfs/xfs_attr_leaf.c fs/xfs/xfs_attr_leaf.h +2 more+1177 -8483 replies
17/22xfs: split remote attribute code outfs/xfs/Makefile fs/xfs/xfs_attr.c fs/xfs/xfs_attr.h +3 more+356 -2981 reply
18/22xfs: add CRC protection to remote attributesfs/xfs/xfs_attr_remote.c fs/xfs/xfs_attr_remote.h+292 -512 replies
19/22xfs: add buffer types to directory and attribute buffersfs/xfs/xfs_attr_leaf.c fs/xfs/xfs_attr_remote.h fs/xfs/xfs_buf_item.h +10 more+323 -902 replies
20/22xfs: buffer type overruns blf_flags fieldfs/xfs/xfs_alloc.c fs/xfs/xfs_attr_leaf.c fs/xfs/xfs_bmap.c +11 more+134 -1060 replies
21/22xfs: add CRC checks to the superblockfs/xfs/xfs_log_recover.c fs/xfs/xfs_mount.c fs/xfs/xfs_mount.h +1 more+172 -450 replies
22/22xfs: implement extended feature masksfs/xfs/xfs_log_recover.c fs/xfs/xfs_mount.c fs/xfs/xfs_sb.h+129 -80 replies

Reviews trailers per patch

None of the 22 patches has a Reviewed-by or Acked-by of their own; the series has one for all of them.

PatchBen Myers
SeriesR-b
1/22
2/22
3/22
4/22
5/22
6/22
7/22
8/22
9/22
10/22
11/22
12/22
13/22
14/22
15/22
16/22
17/22
18/22
19/22
20/22
21/22
22/22

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes.

Read the v1 thread

Cover letter [PATCH 00/22] xfs: metadata CRCs, fourth version

Hi Folks,

New CRC patchset. Previous versions:

http://oss.sgi.com/archives/xfs/2013-01/msg00328.html
http://oss.sgi.com/archives/xfs/2013-02/msg00451.html
http://oss.sgi.com/archives/xfs/2013-03/msg00291.html

This version is based on 3.9-rc4 + TOT xfsdev. 3.9-rc5 has loopback bugs that make it useless for testing, so I've just kept my tree on -rc4.

New in this patch set:

- numerous bug fixes
- cleanups to addresse Bens review comments
- logs entire inode allocation buffers
- reworks the buffer type tracking for log recovery
- fixes the endian issues reported by sparse
- splits out the symlink code rearrangement
- adds support for v5 superblock feature masks
- add mount warnings about CRC support being experimental

Still to do:

- Documentation (half written, not in series)
- DT_* type fields in the directory entries. This can be done with a feature bit if not done in time.
- storage of attributes larger than 256 bytes in shortform attribute forks. Same comment about a feature bit.

The addition of the feature mask support to the superblock added a new field to the superblock - a log compatibility feature mask. This is to allow new transactions and recovery features to be added and prevent kernels that don't understand those features from performing log recovery. The idea is that clean logs can be mounted by kernels that don't support the new feature if everything else is compatible, but if they require log recovery the mount will be aborted. This means pure log changes don't require a compat/incompat/rocompat feature bit to be set.

The result of adding this is that all the old CRC enabled filesystems will not work with this kernel - the CRC field location changed, and that makes the mount fail hard. So a new userspace will be needed to test the CRC side of this patchset. (Coming soon!)

Comments, testing welcome...

-Dave.

_______________________________________________
xfs mailing list
[email protected]
http://oss.sgi.com/mailman/listinfo/xfs