Skip to content

brcmfmac: cleanup and firmware-signalling

Arend van Spriel linux-wireless 1 version New

Get series with b4
b4 am [email protected]

Versions newest first

  1. v1 Latest25 patches 0 repliesNew

Patches in v1 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/25brcmfmac: correct success flag passed by brcmf_sdbrcm_txpkt()drivers/net/wireless/brcm80211/brcmfmac/dhd_sdio.c+1 -10 replies
2/25brcmfmac: minor optimization of brcmf_sdbrcm_txpkt() functiondrivers/net/wireless/brcm80211/brcmfmac/dhd_sdio.c+3 -40 replies
3/25brcmfmac: use skb_cow() in brcmf_sdbrcm_txpkt() to assure alignmentdrivers/net/wireless/brcm80211/brcmfmac/dhd_sdio.c+6 -190 replies
4/25brcmfmac: determine the wiphy->bands property correctly.drivers/net/wireless/brcm80211/brcmfmac/dhd.h drivers/net/wireless/brcm80211/brcmfmac/wl_cfg80211.c drivers/net/wireless/brcm80211/include/brcmu_wifi.h+278 -820 replies
5/25brcmfmac: hookup firmware signalling to firmware interface eventsdrivers/net/wireless/brcm80211/brcmfmac/dhd.h drivers/net/wireless/brcm80211/brcmfmac/dhd_linux.c drivers/net/wireless/brcm80211/brcmfmac/fweh.c +2 more+148 -610 replies
6/25brcmfmac: handle firmware signal for updating mac descriptor infodrivers/net/wireless/brcm80211/brcmfmac/dhd_dbg.c drivers/net/wireless/brcm80211/brcmfmac/dhd_dbg.h drivers/net/wireless/brcm80211/brcmfmac/fwsignal.c+112 -150 replies
7/25brcmfmac: add handler for credit map firmware eventsdrivers/net/wireless/brcm80211/brcmfmac/fwsignal.c+24 -00 replies
8/25brcmfmac: add firmware-signalling cleanup functiondrivers/net/wireless/brcm80211/brcmfmac/fwsignal.c+46 -50 replies
9/25brcmfmac: allow stopping netif queue for different reasonsdrivers/net/wireless/brcm80211/brcmfmac/dhd.h drivers/net/wireless/brcm80211/brcmfmac/dhd_linux.c+38 -80 replies
10/25brcmfmac: add definitions for handling sk_buff control buffer datadrivers/net/wireless/brcm80211/brcmfmac/fwsignal.c+107 -330 replies
11/25brcmfmac: perform filtered firmware-signalling cleanup upon DEL_IFdrivers/net/wireless/brcm80211/brcmfmac/fwsignal.c+13 -20 replies
12/25brcmfmac: add firmware-signalling hanger functionsdrivers/net/wireless/brcm80211/brcmfmac/fwsignal.c+197 -00 replies
13/25brcmfmac: add optional bus callback definition for tx queue cleanupdrivers/net/wireless/brcm80211/brcmfmac/dhd_bus.h drivers/net/wireless/brcm80211/brcmfmac/dhd_sdio.c drivers/net/wireless/brcm80211/brcmfmac/fwsignal.c+56 -30 replies
14/25brcmfmac: add flow-control mode to firmware signallingdrivers/net/wireless/brcm80211/brcmfmac/dhd.h drivers/net/wireless/brcm80211/brcmfmac/dhd_linux.c drivers/net/wireless/brcm80211/brcmfmac/fwsignal.c +1 more+41 -110 replies
15/25brcmfmac: enable tx status signallingdrivers/net/wireless/brcm80211/brcmfmac/dhd_dbg.c drivers/net/wireless/brcm80211/brcmfmac/dhd_dbg.h drivers/net/wireless/brcm80211/brcmfmac/dhd_linux.c +2 more+455 -870 replies
16/25brcmfmac: fix handling sk_buff cleanup upon bus tx failuredrivers/net/wireless/brcm80211/brcmfmac/dhd_linux.c drivers/net/wireless/brcm80211/brcmfmac/fwsignal.c drivers/net/wireless/brcm80211/brcmfmac/fwsignal.h+33 -140 replies
17/25brcmfmac: avoid error output in receive pathdrivers/net/wireless/brcm80211/brcmfmac/fwsignal.c+3 -30 replies
18/25brcmfmac: avoid error output on header only packetdrivers/net/wireless/brcm80211/brcmfmac/dhd_cdc.c+2 -20 replies
19/25brcmfmac: add dedicated log level for low-level sdio debuggingdrivers/net/wireless/brcm80211/brcmfmac/bcmsdh.c drivers/net/wireless/brcm80211/brcmfmac/bcmsdh_sdmmc.c drivers/net/wireless/brcm80211/brcmfmac/dhd_dbg.h +1 more+63 -620 replies
20/25brcmfmac: initialize struct brcmf_fws_info fields before iovardrivers/net/wireless/brcm80211/brcmfmac/fwsignal.c+4 -40 replies
21/25brcmfmac: correct specified length from FIFOCREDITBACK signaldrivers/net/wireless/brcm80211/brcmfmac/fwsignal.c+1 -10 replies
22/25brcmfmac: move brcmf_fws_{de,}init() functionsdrivers/net/wireless/brcm80211/brcmfmac/fwsignal.c+68 -680 replies
23/25brcmfmac: only allocate firmware-signalling resources if requireddrivers/net/wireless/brcm80211/brcmfmac/dhd_linux.c drivers/net/wireless/brcm80211/brcmfmac/fwsignal.c+10 -70 replies
24/25brcmfmac: no flow-control tlv signals when fcmode is NONEdrivers/net/wireless/brcm80211/brcmfmac/fwsignal.c+6 -60 replies
25/25brcmfmac: enable sk_buff queueing when credits depletedrivers/net/wireless/brcm80211/brcmfmac/dhd_dbg.c drivers/net/wireless/brcm80211/brcmfmac/dhd_dbg.h drivers/net/wireless/brcm80211/brcmfmac/fwsignal.c+627 -600 replies

Reviews trailers per patch

All 25 patches have a Reviewed-by or Acked-by.

PatchPieter-Paul GiesbertsHante MeulemanPiotr HaberFranky (Zhenhui) LinArend van Spriel
1/25R-b R-b R-b R-b
2/25R-b R-b R-b R-b
3/25R-b R-b R-b
4/25R-b R-b R-b
5/25R-b R-b R-b
6/25R-b R-b R-b
7/25R-b R-b R-b
8/25R-b R-b R-b
9/25R-b R-b R-b
10/25R-b R-b R-b
11/25R-b R-b R-b
12/25R-b R-b R-b
13/25R-b R-b R-b R-b
14/25R-b R-b R-b
15/25R-b R-b R-b
16/25R-b R-b R-b
17/25R-b R-b
18/25R-b R-b
19/25R-b R-b
20/25R-b R-b R-b
21/25R-b R-b R-b
22/25R-b R-b R-b
23/25R-b R-b
24/25R-b R-b R-b
25/25R-b R-b

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes. Scroll the table sideways for all 5 reviewers.

Read the v1 thread

Cover letter [PATCH 00/25] brcmfmac: cleanup and firmware-signalling

This series contain some rework just for the sake of cleanup and to prepare for handling firmware signals properly. Firmware-signalling is used to provide flow-control between host driver and firmware using tlv based firmware signals.

The series is intended for v3.10 kernel and applies to the master branch of the wireless-next repository.

Arend van Spriel (23):
brcmfmac: correct success flag passed by brcmf_sdbrcm_txpkt()
brcmfmac: minor optimization of brcmf_sdbrcm_txpkt() function
brcmfmac: use skb_cow() in brcmf_sdbrcm_txpkt() to assure alignment
brcmfmac: hookup firmware signalling to firmware interface events
brcmfmac: handle firmware signal for updating mac descriptor info
brcmfmac: add handler for credit map firmware events
brcmfmac: add firmware-signalling cleanup function
brcmfmac: allow stopping netif queue for different reasons
brcmfmac: add definitions for handling sk_buff control buffer data
brcmfmac: perform filtered firmware-signalling cleanup upon DEL_IF
brcmfmac: add firmware-signalling hanger functions
brcmfmac: add optional bus callback definition for tx queue cleanup
brcmfmac: add flow-control mode to firmware signalling
brcmfmac: enable tx status signalling
brcmfmac: fix handling sk_buff cleanup upon bus tx failure
brcmfmac: avoid error output in receive path
brcmfmac: add dedicated log level for low-level sdio debugging
brcmfmac: initialize struct brcmf_fws_info fields before iovar
brcmfmac: correct specified length from FIFOCREDITBACK signal
brcmfmac: move brcmf_fws_{de,}init() functions
brcmfmac: only allocate firmware-signalling resources if required
brcmfmac: no flow-control tlv signals when fcmode is NONE
brcmfmac: enable sk_buff queueing when credits deplete

Hante Meuleman (1):
brcmfmac: determine the wiphy->bands property correctly.

Piotr Haber (1):
brcmfmac: avoid error output on header only packet

 drivers/net/wireless/brcm80211/brcmfmac/bcmsdh.c   |   30 +-
 .../net/wireless/brcm80211/brcmfmac/bcmsdh_sdmmc.c |   60 +-
 drivers/net/wireless/brcm80211/brcmfmac/dhd.h      |   32 +-
 drivers/net/wireless/brcm80211/brcmfmac/dhd_bus.h  |   13 +-
 drivers/net/wireless/brcm80211/brcmfmac/dhd_cdc.c  |    4 +-
 drivers/net/wireless/brcm80211/brcmfmac/dhd_dbg.c  |   46 +-
 drivers/net/wireless/brcm80211/brcmfmac/dhd_dbg.h  |   16 +
 .../net/wireless/brcm80211/brcmfmac/dhd_linux.c    |   79 +-
 drivers/net/wireless/brcm80211/brcmfmac/dhd_sdio.c |   76 +-
 drivers/net/wireless/brcm80211/brcmfmac/fweh.c     |   10 +-
 drivers/net/wireless/brcm80211/brcmfmac/fwsignal.c | 1714 ++++++++++++++++++--
 drivers/net/wireless/brcm80211/brcmfmac/fwsignal.h |    8 +
 .../net/wireless/brcm80211/brcmfmac/wl_cfg80211.c  |  326 +++-
 .../net/wireless/brcm80211/include/brcmu_wifi.h    |   28 +-
 14 files changed, 2113 insertions(+), 329 deletions(-)
Signature · 1 line
1.7.10.4