Skip to content

perf tools: Cleanup for sort keys (v2)

Namhyung Kim lkml 1 version In review

Get series with b4
b4 am [email protected]

Versions newest first

  1. v1 Latest10 patches 10 repliesIn review

Patches in v1 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/10perf sort: Factor out common code in sort_dimension__add()tools/perf/util/sort.c+17 -240 replies
2/10perf sort: Separate out memory-specific sort keystools/perf/builtin-report.c tools/perf/util/sort.c tools/perf/util/sort.h+44 -164 replies
3/10perf sort: Add 'addr' sort keytools/perf/util/hist.c tools/perf/util/hist.h tools/perf/util/sort.c +1 more+34 -12 replies
4/10perf sort: Add 'addr_to/from' sort keytools/perf/util/hist.c tools/perf/util/hist.h tools/perf/util/sort.c +1 more+56 -00 replies
5/10perf sort: Update documentation for sort keystools/perf/Documentation/perf-diff.txt tools/perf/Documentation/perf-report.txt tools/perf/Documentation/perf-top.txt +3 more+12 -80 replies
6/10perf hists: Move column length setting codetools/perf/util/hist.c+6 -70 replies
7/10perf sort: Cleanup sort__has_sym settingtools/perf/util/sort.c+1 -40 replies
8/10perf top: Use sort__has_symtools/perf/builtin-top.c tools/perf/util/top.h+3 -100 replies
9/10perf hist browser: Use sort__has_symtools/perf/ui/browsers/hists.c+2 -72 replies
10/10perf sort: Consolidate sort_entry__setup_elide()tools/perf/builtin-diff.c tools/perf/builtin-report.c tools/perf/builtin-top.c +2 more+47 -292 replies

Reviews trailers per patch

No Reviewed-by, Acked-by or Tested-by trailers for v1 yet.

Read the v1 thread

Cover letter [PATCHSET 00/10] perf tools: Cleanup for sort keys (v2)

Hello,

This is a second version of my sort key cleanup series. I Added helper function for adding sort key and used unmap_ip() function for printing symbol address as Jiri commented. But didn't change name of the sort keys to 'ip'. If you really think I should change, I'm okay to do it though. I also cleaned up sort__has_sym and sort key eliding code in this version.

You can get it from 'perf/sort-v4' branch on my tree at:

git://git.kernel.org/pub/scm/linux/kernel/namhyung/linux-perf.git

Any comments are welcome, thanks.
Namhyung

Namhyung Kim (10):
perf sort: Factor out common code in sort_dimension__add() perf sort: Separate out memory-specific sort keys perf sort: Add 'addr' sort key
perf sort: Add 'addr_to/from' sort key
perf sort: Update documentation for sort keys perf hists: Move column length setting code
perf sort: Cleanup sort__has_sym setting
perf top: Use sort__has_sym
perf hist browser: Use sort__has_sym
perf sort: Consolidate sort_entry__setup_elide()

 tools/perf/Documentation/perf-diff.txt   |   2 +-
 tools/perf/Documentation/perf-report.txt |   5 +-
 tools/perf/Documentation/perf-top.txt    |   2 +-
 tools/perf/builtin-diff.c                |   6 +-
 tools/perf/builtin-report.c              |  28 +----
 tools/perf/builtin-top.c                 |  19 +--
 tools/perf/ui/browsers/hists.c           |   9 +-
 tools/perf/util/hist.c                   |  17 +--
 tools/perf/util/hist.h                   |   5 +-
 tools/perf/util/sort.c                   | 201 +++++++++++++++++++++++++------
 tools/perf/util/sort.h                   |  25 ++--
 tools/perf/util/top.h                    |   1 -
 12 files changed, 218 insertions(+), 102 deletions(-)
Signature · 1 line
1.7.11.7