Skip to content

Remove ~25 lines of duplicate code

Lukas Fleischer git 1 version In review

Get series with b4
b4 am [email protected]

Versions newest first

  1. v1 Latest3 patches 2 repliesIn review

Patches in v1 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/3Make read_index_data() publicattr.c cache.h read-cache.c+35 -342 replies
2/3Add size parameter to read_index_data()attr.c cache.h read-cache.c+6 -30 replies
3/3convert.c: Remove duplicate codeconvert.c+2 -250 replies

Reviews trailers per patch

No Reviewed-by, Acked-by or Tested-by trailers for v1 yet.

Read the v1 thread

Cover letter [PATCH 0/3] Remove ~25 lines of duplicate code

Merge read_index_data() and has_cr_in_index() which are almost 1:1 copies of each other.

Lukas Fleischer (3):
Make read_index_data() public
Add size parameter to read_index_data()
convert.c: Remove duplicate code

 attr.c       | 35 +----------------------------------
 cache.h      |  1 +
 convert.c    | 27 ++-------------------------
 read-cache.c | 36 ++++++++++++++++++++++++++++++++++++
 4 files changed, 40 insertions(+), 59 deletions(-)
Signature · 1 line
1.8.2.675.gda3bb24.dirty