Skip to content

block: Overriding the backing file with -drive

Kevin Wolf qemu-devel 1 version In review

Get series with b4
b4 am [email protected]

Versions newest first

  1. v1 Latest15 patches 19 repliesIn review

Patches in v1 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/15block: Fail gracefully when using a format driver on protocol levelblock.c tests/qemu-iotests/051 tests/qemu-iotests/051.out+24 -03 replies
2/15block: Add driver-specific options for backing filesblock.c block/mirror.c include/block/block.h+25 -61 reply
3/15block: Enable filename optionblock.c+27 -41 reply
4/15raw-posix: Use bdrv_open options instead of filenameblock/raw-posix.c+45 -121 reply
5/15raw-win32: Use bdrv_open options instead of filenameblock/raw-win32.c+47 -101 reply
6/15blkdebug: Use bdrv_open options instead of filenameblock/blkdebug.c+77 -261 reply
7/15blkverify: Use bdrv_open options instead of filenameblock/blkverify.c+76 -181 reply
8/15curl: Use bdrv_open options instead of filenameblock/curl.c+102 -511 reply
9/15gluster: Use bdrv_open options instead of filenameblock/gluster.c+31 -11 reply
10/15iscsi: Use bdrv_open options instead of filenameblock/iscsi.c+37 -21 reply
11/15rbd: Use bdrv_open options instead of filenameblock/rbd.c+30 -11 reply
12/15sheepdog: Use bdrv_open options instead of filenameblock/sheepdog.c+31 -11 reply
13/15vvfat: Use bdrv_open options instead of filenameblock/vvfat.c+158 -521 reply
14/15block: Remove filename parameter from .bdrv_file_open()block.c block/blkdebug.c block/blkverify.c +10 more+21 -412 replies
15/15block: Allow overriding backing.file.filenameblock.c+3 -11 reply

Reviews trailers per patch

14 of 15 patches have a Reviewed-by or Acked-by.

PatchEric Blake
1/15
2/15R-b
3/15R-b
4/15R-b
5/15R-b
6/15R-b
7/15R-b
8/15R-b
9/15R-b
10/15R-b
11/15R-b
12/15R-b
13/15R-b
14/15R-b R-b
15/15R-b

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes.

Read the v1 thread

Cover letter [Qemu-devel] [PATCH 00/15] block: Overriding the backing file with -drive

This is the next part of the driver-specific options. Looks like we're getting closer to pass file descriptors for the whole backing file chain. In fact, I hope we're now only lacking QMP support before we can actually use it. :-)

This series adds support for the backing.* options namespace, and allows to use the file.filename option to configure the filename string for non-top-level BlockDriverStates. In the end you can use things like:

-drive file=test.qcow2,backing.file.filename=/dev/fdset/1, backing.backing.file.driver=nbd,backing.backing.file.host=localhost

On another note, I'm still not sure whether I should leave all of this work enabled for 1.5, or if we wouldn't be better off with disabling it for the release so that we have some additional months before we commit to the interface. Any opinions?

Kevin Wolf (15):
block: Fail gracefully when using a format driver on protocol level
block: Add driver-specific options for backing files
block: Enable filename option
raw-posix: Use bdrv_open options instead of filename
raw-win32: Use bdrv_open options instead of filename
blkdebug: Use bdrv_open options instead of filename
blkverify: Use bdrv_open options instead of filename
curl: Use bdrv_open options instead of filename
gluster: Use bdrv_open options instead of filename
iscsi: Use bdrv_open options instead of filename
rbd: Use bdrv_open options instead of filename
sheepdog: Use bdrv_open options instead of filename
vvfat: Use bdrv_open options instead of filename
block: Remove filename parameter from .bdrv_file_open()
block: Allow overriding backing.file.filename

 block.c                    |  65 ++++++++++++--
 block/blkdebug.c           | 102 ++++++++++++++++------
 block/blkverify.c          |  93 ++++++++++++++++----
 block/curl.c               | 152 +++++++++++++++++++++-----------
 block/gluster.c            |  34 +++++++-
 block/iscsi.c              |  40 ++++++++-
 block/mirror.c             |   2 +-
 block/nbd.c                |   3 +-
 block/raw-posix.c          |  70 ++++++++++-----
 block/raw-win32.c          |  59 ++++++++++---
 block/rbd.c                |  32 ++++++-
 block/sheepdog.c           |  33 ++++++-
 block/vvfat.c              | 211 +++++++++++++++++++++++++++++++++------------
 include/block/block.h      |   2 +-
 include/block/block_int.h  |   3 +-
 tests/qemu-iotests/051     |   7 ++
 tests/qemu-iotests/051.out |  10 +++
 17 files changed, 713 insertions(+), 205 deletions(-)
Signature · 1 line
1.8.1.4