Skip to content

bnx2x: refactor nvram related code and update version

Dmitry Kravkov netdev 4 versions – In review

Get series with b4
b4 am [email protected]

Versions newest first · linked by author and title

  1. v4 Latest6 patches 1 replyIn review
  2. v36 patches 1 replySuperseded
  3. v24 patches 4 repliesSuperseded
Earlier versions · 1
VersionPostedPatchesRepliesStatus
v14 patches4 repliesSuperseded

Changes in v4 from the cover letter

4/6 * removed some emtry lines
* fixed lines over 80 chars

Patches in v4 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/6bnx2x: refactor nvram read proceduredrivers/net/ethernet/broadcom/bnx2x/bnx2x_ethtool.c+21 -70 replies
2/6bnx2x: fix byte-by-byte nvram write for BE machinesdrivers/net/ethernet/broadcom/bnx2x/bnx2x_ethtool.c+7 -80 replies
3/6bnx2x: remove non-necessary assignmentdrivers/net/ethernet/broadcom/bnx2x/bnx2x_ethtool.c+1 -40 replies
4/6bnx2x: add additional regions for CRC memory testdrivers/net/ethernet/broadcom/bnx2x/bnx2x.h drivers/net/ethernet/broadcom/bnx2x/bnx2x_ethtool.c+185 -230 replies
5/6bnx2x: allow nvram test to run when device is downdrivers/net/ethernet/broadcom/bnx2x/bnx2x_ethtool.c+10 -90 replies
6/6bnx2x: update version to 1.78.17-0drivers/net/ethernet/broadcom/bnx2x/bnx2x.h+2 -20 replies

Reviews trailers per patch

No Reviewed-by, Acked-by or Tested-by trailers for v4 yet.

Read the v4 thread

Cover letter [PATCH v4 net-next 0/6] bnx2x: refactor nvram related code and update version

Hi Dave,

Please cosider appliyng the series to net-next.

Changes for v2->v3:
1/4 * was separated into 3 patches [1-3/6] pointed out by Francois Romieu
* some cosmetics and beautifications was applied.
* bnx2x_nvram_read32 rearranged according to Francois Romieu's comments

2/4 * move to be 4/6
* some code were extracted into fuctions in order to stop processing once error was detected.
* removed inaccurate decoding of errors - left only error messages according to Francois Romieu's comments
* removed useless init according to Francois Romieu's comment

Changes for v3->v4
4/6 * removed some emtry lines
* fixed lines over 80 chars

Thanks
Dmitry