Skip to content

Bluetooth: L2CAP cleanups and fixes

Johan Hedberg linux-bluetooth 1 version In review

Get series with b4
b4 am [email protected]

Versions newest first

  1. v1 Latest13 patches 6 repliesIn review

Patches in v1 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/13Bluetooth: Handle LE L2CAP signalling in its own functionnet/bluetooth/l2cap_core.c+48 -50 replies
2/13Bluetooth: Create independent LE signalling defines and structsinclude/net/bluetooth/l2cap.h net/bluetooth/l2cap_core.c+42 -160 replies
3/13Bluetooth: Rename L2CAP_CID_LE_DATA to L2CAP_CID_ATTinclude/net/bluetooth/l2cap.h net/bluetooth/l2cap_core.c net/bluetooth/l2cap_sock.c+10 -100 replies
4/13Bluetooth: Fix LE vs BR/EDR selection when connectingnet/bluetooth/l2cap_core.c+1 -14 replies
5/13Bluetooth: Fix EBUSY condition test in l2cap_chan_connectnet/bluetooth/l2cap_core.c+4 -100 replies
6/13Bluetooth: Fix hardcoding ATT CID in __l2cap_chan_add()net/bluetooth/l2cap_core.c+6 -20 replies
7/13Bluetooth: Add clarifying comment to l2cap_conn_ready()net/bluetooth/l2cap_core.c+3 -00 replies
8/13Bluetooth: Fix duplicate call to l2cap_chan_ready()net/bluetooth/l2cap_core.c+0 -20 replies
9/13Bluetooth: Remove useless sk variable in l2cap_le_conn_readynet/bluetooth/l2cap_core.c+3 -50 replies
10/13Bluetooth: Remove unnecessary L2CAP channel state checknet/bluetooth/l2cap_core.c+1 -40 replies
11/13Bluetooth: Simplify hci_conn_hold/drop logic for L2CAPnet/bluetooth/l2cap_core.c+5 -30 replies
12/13Bluetooth: Remove useless hci_conn disc_timeout settingnet/bluetooth/l2cap_core.c+0 -20 replies
13/13Bluetooth: Fix multiple LE socket handlingnet/bluetooth/l2cap_core.c+8 -41 reply

Reviews trailers per patch

None of the 13 patches has a Reviewed-by or Acked-by of their own; the series has one for all of them.

PatchMarcel Holtmann
SeriesA-b
1/13
2/13
3/13
4/13
5/13
6/13
7/13
8/13
9/13
10/13
11/13
12/13
13/13

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes.

Read the v1 thread

Cover letter [PATCH 00/13] Bluetooth: L2CAP cleanups and fixes

Hi,

This set of patches contains some cleanups and fixes for future L2CAP work. The L2CAP usage in coming core spec versions will no longer be as constrined as it has so far with extensions to the LE signalling channel etc. This means that we really do need separate code paths for LE signalling instead of sharing BR/EDR related signalling code. The patches to split this up keep the same functionality as before (for now) but ensure that we have dedicated functions and structs for LE.

Johan

----------------------------------------------------------------
Johan Hedberg (13):
Bluetooth: Handle LE L2CAP signalling in its own function
Bluetooth: Create independent LE signalling defines and structs
Bluetooth: Rename L2CAP_CID_LE_DATA to L2CAP_CID_ATT
Bluetooth: Fix LE vs BR/EDR selection when connecting
Bluetooth: Fix EBUSY condition test in l2cap_chan_connect
Bluetooth: Fix hardcoding ATT CID in __l2cap_chan_add()
Bluetooth: Add clarifying comment to l2cap_conn_ready()
Bluetooth: Fix duplicate call to l2cap_chan_ready()
Bluetooth: Remove useless sk variable in l2cap_le_conn_ready
Bluetooth: Remove unnecessary L2CAP channel state check
Bluetooth: Simplify hci_conn_hold/drop logic for L2CAP
Bluetooth: Remove useless hci_conn disc_timeout setting
Bluetooth: Fix multiple LE socket handling

 include/net/bluetooth/l2cap.h |   36 ++++++++--
 net/bluetooth/l2cap_core.c    |  145 ++++++++++++++++++++++++++---------------
 net/bluetooth/l2cap_sock.c    |    4 +-
 3 files changed, 126 insertions(+), 59 deletions(-)