Skip to content

linux-user: Fix MIPS16/microMIPS signal handling

Kwok Cheung Yeung qemu-devel 2 versions – In review

Get series with b4
b4 am [email protected]

Versions newest first · linked by author and title

  1. v2 Latest2 patches 1 replyIn review
  2. v11 patch 1 replySuperseded

Changes in v2 from the cover letter

- Add fixes for signal return and delay slot instructions
- Refactor code

Patches in v2 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/2linux-user: Fix MIPS ISA transitions during signal handlinglinux-user/signal.c+13 -00 replies
2/2linux-user: Save the correct resume address for MIPS signal handlinglinux-user/signal.c target-mips/cpu.h target-mips/helper.c+5 -30 replies

Reviews trailers per patch

No Reviewed-by, Acked-by or Tested-by trailers for v2 yet.

Read the v2 thread

Cover letter [Qemu-devel] [PATCH v2 0/2] linux-user: Fix MIPS16/microMIPS signal handling

These patches fix various issues related to signal handling in user mode emulation for the MIPS architecture.

- When a MIPS16/microMIPS signal handler is called, the program segfaults because the PC is set to an invalid address.
- When returning from a signal handler, the ISA mode is not set to that of the resume instruction.
- When the faulting instruction is in a branch delay slot, the resume address is set to that of the instruction rather than the branch, resulting in incorrect behaviour. The flag indicating that the instruction is in a delay slot is also not cleared.

v1 -> v2:
- Add fixes for signal return and delay slot instructions
- Refactor code

Kwok Cheung Yeung (2):
linux-user: Fix MIPS ISA transitions during signal handling
linux-user: Save the correct resume address for MIPS signal handling

 linux-user/signal.c  | 16 +++++++++++++++-
 target-mips/cpu.h    |  1 +
 target-mips/helper.c |  4 ++--
 3 files changed, 18 insertions(+), 3 deletions(-)
Signature · 1 line
1.8.1.2