Skip to content

drm/i915: remove pch_edp encoder state variable

Imre Deak intel-gfx 2 versions – In review

Get series with b4
b4 am [email protected]

Versions newest first · linked by author and title

  1. v2 Latest7 patches 2 repliesIn review
  2. v16 patches 2 repliesSuperseded

Changes in v2 from the cover letter

- reduce debug verbosity (Daniel)
- make comment about not setting the encoder type clearer (Ville)

Patches in v2 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/7drm/i915: use enc_to_intel_dp() instead of opencoding the samedrivers/gpu/drm/i915/intel_drv.h+5 -70 replies
2/7drm/i915: hsw: replace !is_pch_edp() with port==PORT_Adrivers/gpu/drm/i915/intel_display.c+1 -10 replies
3/7drm/i915: ilk-ivb: replace !is_pch_edp() with port==PORT_Adrivers/gpu/drm/i915/intel_display.c+3 -70 replies
4/7drm/i915: stop using is_pch_edp() in intel_dp_init_connector()drivers/gpu/drm/i915/intel_dp.c+22 -110 replies
5/7drm/i915: stop using is_pch_edp() in is_cpu_edp()drivers/gpu/drm/i915/intel_dp.c+11 -62 replies
6/7drm/i915: remove is_pch_edp() helpers and state variabledrivers/gpu/drm/i915/intel_dp.c drivers/gpu/drm/i915/intel_drv.h+0 -380 replies
7/7drm/i915: print DP init debug messages from a single placedrivers/gpu/drm/i915/intel_display.c drivers/gpu/drm/i915/intel_dp.c+7 -90 replies

Reviews trailers per patch

No Reviewed-by, Acked-by or Tested-by trailers for v2 yet.

Read the v2 thread

Cover letter [PATCH v2 0/7] drm/i915: remove pch_edp encoder state variable

Since whether a specific eDP port is on CPU or on PCH is fixed and depends only on which digital port it is, we don't really need state tracking for it. So remove it and instead check for the port and if needed the machine type (for ValleyView).

The assumption in the code before and after the change:

Before ILK there is no eDP. Starting from ILK we can have eDP ports on port A and D:

Port A and for ValleyView port C is always a CPU side eDP port, if the port exists.

Port D is a PCH side eDP port if there is a PCH and VBT says it's an eDP port.

Tested only on IVB.

v2:
- reduce debug verbosity (Daniel)
- make comment about not setting the encoder type clearer (Ville)

Imre Deak (7):
drm/i915: use enc_to_intel_dp() instead of opencoding the same drm/i915: hsw: replace !is_pch_edp() with port==PORT_A drm/i915: ilk-ivb: replace !is_pch_edp() with port==PORT_A drm/i915: stop using is_pch_edp() in intel_dp_init_connector() drm/i915: stop using is_pch_edp() in is_cpu_edp() drm/i915: remove is_pch_edp() helpers and state variable drm/i915: print DP init debug messages from a single place

 drivers/gpu/drm/i915/intel_display.c |   24 +++-------
 drivers/gpu/drm/i915/intel_dp.c      |   84 ++++++++++++++--------------------
 drivers/gpu/drm/i915/intel_drv.h     |   14 ++----
 3 files changed, 46 insertions(+), 76 deletions(-)
Signature · 1 line
1.7.10.4