Skip to content

Fix disable of unused clk/regulator with deferred probe

Saravana Kannan linux-arm-kernel linux-arm-msm lkml 1 version In review

Get series with b4
b4 am [email protected]

Versions newest first

  1. v1 Latest3 patches 14 repliesIn review

Patches in v1 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/3driver core: Add API to wait for deferred probe to complete during initdrivers/base/dd.c include/linux/device.h+9 -014 replies
2/3clk: Disable unused clocks after deferred probing is donedrivers/clk/clk.c+3 -10 replies
3/3regulator: core: Disable unused regulators after deferred probing is donedrivers/regulator/core.c+3 -10 replies

Reviews trailers per patch

No Reviewed-by, Acked-by or Tested-by trailers for v1 yet.

Read the v1 thread

Cover letter [PATCH 0/3] Fix disable of unused clk/regulator with deferred probe

Clock and regulator frameworks have support for disabling unused clocks and regulators at system init to save power when bootloaders leave them in a less than desirable state. If no driver has requested for a clock/regulator to be ON by the time kernel init reaches late_initcall level, they were considered unused.

This worked well/good enough for compiled in drivers before deferred probe was introduced. But with deferred probe, it's quite likely that devices that match with compiled in drivers will continue to probe well past late_initcall (at least as far as I can understand). So, we need to wait for deferred probing during kernel init to complete before we do the disable of unused clocks/regulators.

If there's a better or more obvious solution, I'm all ears. Another approach would have been to add a "probe_done_initcall" level. But that seems overkill and I don't think adding yet another initcall level is a great idea.

Thanks,
Saravana

Saravana Kannan (3):
driver core: Add API to wait for deferred probe to complete during
init
clk: Disable unused clocks after deferred probing is done
regulator: core: Disable unused regulators after deferred probing is
done

 drivers/base/dd.c        |    8 ++++++++
 drivers/clk/clk.c        |    4 +++-
 drivers/regulator/core.c |    4 +++-
 include/linux/device.h   |    1 +
 4 files changed, 15 insertions(+), 2 deletions(-)
Signature · 4 lines
1.7.8.3

The Qualcomm Innovation Center, Inc. is a member of the Code Aurora Forum,
hosted by The Linux Foundation