Skip to content

Exported funtions that are marked inline

Denis Efremov linux-arm-kernel linux-fsdevel linux-m68k linux-mips linux-scsi linux-wireless linuxppc-dev lkml netdev netfilter sparclinux 1 version Applied

Status from this message: Applied, thanks.

Get series with b4
b4 am [email protected]

Versions newest first

  1. v1 Latest21 patches 17 repliesApplied

Patches in v1 Applied

#Subject and filesSizeRepliesApplied
1/21libiscsi: remove inline marking of EXPORT_SYMBOL functionsdrivers/scsi/libiscsi.c drivers/scsi/libiscsi_tcp.c+5 -50 replies
2/21fs: remove inline marking of EXPORT_SYMBOL functionsfs/bio.c fs/block_dev.c fs/buffer.c+3 -32 replies
3/21x86: remove inline marking of EXPORT_SYMBOL functionsarch/x86/lib/delay.c arch/x86/um/delay.c+2 -21 reply
4/21NFC: remove inline marking of EXPORT_SYMBOL functionsnet/nfc/core.c+1 -10 replies
5/219p: remove inline marking of EXPORT_SYMBOL functionsnet/9p/client.c+2 -20 replies
6/21staging: nvec: remove inline marking of EXPORT_SYMBOL functionsdrivers/staging/nvec/nvec.c+1 -10 replies
7/21netfilter: nf_nat: remove inline marking of EXPORT_SYMBOL functionsnet/netfilter/nf_nat_core.c+1 -11 reply
8/21iwlegacy: remove inline marking of EXPORT_SYMBOL functionsdrivers/net/wireless/iwlegacy/common.c+1 -10 replies
9/21dw_dmac: remove inline marking of EXPORT_SYMBOL functionsdrivers/dma/dw_dmac.c+2 -22 replies
10/21mm: filemap: remove inline marking of EXPORT_SYMBOL functionsmm/filemap.c+1 -10 replies
11/21ipv4: ip_output: remove inline marking of EXPORT_SYMBOL functionsnet/ipv4/ip_output.c+1 -11 reply
12/21metag: delay: remove inline marking of EXPORT_SYMBOL functionsarch/metag/lib/delay.c+1 -11 reply
13/21openrisc: delay: remove inline marking of EXPORT_SYMBOL functionsarch/openrisc/lib/delay.c+1 -11 reply
14/21arm64: delay: remove inline marking of EXPORT_SYMBOL functionsarch/arm64/lib/delay.c+1 -11 reply
15/21arch/tile: remove inline marking of EXPORT_SYMBOL functionsarch/tile/lib/spinlock_32.c+1 -11 reply
16/21sparc: remove inline marking of EXPORT_SYMBOL functionsarch/sparc/prom/tree_64.c+7 -70 replies
17/21CRISv32: remove inline marking of EXPORT_SYMBOL functionsarch/cris/arch-v32/kernel/cache.c+1 -11 reply
18/21m68k/sun3/: remove inline marking of EXPORT_SYMBOL functionsarch/m68k/sun3/sun3dvma.c+1 -10 replies
18/21m68k/sun3/: remove inline marking of EXPORT_SYMBOL functionsarch/m68k/sun3/sun3dvma.c+1 -12 replies
19/21MIPS: MSP71xx: remove inline marking of EXPORT_SYMBOL functionsarch/mips/pmcs-msp71xx/msp_prom.c+1 -10 replies
20/21powerpc/ps3: remove inline marking of EXPORT_SYMBOL functionsarch/powerpc/platforms/ps3/spu.c+1 -13 replies
21/21ARM: remove inline marking of EXPORT_SYMBOL functionsarch/arm/mach-sa1100/jornada720_ssp.c+1 -10 replies

Reviews trailers per patch

7 of 22 patches have a Reviewed-by or Acked-by.

PatchCatalin MarinasWill DeaconGeert UytterhoevenGeoff LevandViresh KumarJesper Nilsson
1/21
2/21
3/21
4/21
5/21
6/21
7/21
8/21
9/21A-b
10/21
11/21
12/21
13/21A-b
14/21A-b
15/21
16/21
17/21A-b
18/21A-b A-b
18/21A-b A-b
19/21
20/21A-b
21/21

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes. Scroll the table sideways for all 6 reviewers.

Read the v1 thread

Cover letter [PATCH 00/21] Exported funtions that are marked inline

Hello everyone,
this is a patchset to remove inline marking of exported functions. Patchset is motivated by
https://lkml.org/lkml/2012/5/10/545 (af3b56289)

I run some tests and inspect the binaries. (You can find the tests
here: https://bitbucket.org/evdenis/tests/src) And it seems (at least on my configuration) that EXPORT_SYMBOL completely revokes inline directive. GCC can handle this, but other compilers may be confused by these two directives. Anyway, you can't inline function that you expect not to be available for modules with incompatible license and to be available for the rest.

The tool I use to check the sources:
https://bitbucket.org/evdenis/export_checking.git

arch/arm/mach-sa1100/jornada720_ssp.c  |  2 +-
arch/arm64/lib/delay.c                 |  2 +-
arch/cris/arch-v32/kernel/cache.c      |  2 +-
arch/m68k/sun3/sun3dvma.c              |  2 +-
arch/metag/lib/delay.c                 |  2 +-
arch/mips/pmcs-msp71xx/msp_prom.c      |  2 +-
arch/openrisc/lib/delay.c              |  2 +-
arch/powerpc/platforms/ps3/spu.c       |  2 +-
arch/sparc/prom/tree_64.c              | 14 +++++++-------
arch/tile/lib/spinlock_32.c            |  2 +-
arch/x86/lib/delay.c                   |  2 +-
arch/x86/um/delay.c                    |  2 +-
drivers/dma/dw_dmac.c                  |  4 ++--
drivers/net/wireless/iwlegacy/common.c |  2 +-
drivers/scsi/libiscsi.c                |  2 +-
drivers/scsi/libiscsi_tcp.c            |  8 ++++----
drivers/staging/nvec/nvec.c            |  2 +-
fs/bio.c                               |  2 +-
fs/block_dev.c                         |  2 +-
fs/buffer.c                            |  2 +-
mm/filemap.c                           |  2 +-
net/9p/client.c                        |  4 ++--
net/ipv4/ip_output.c                   |  2 +-
net/netfilter/nf_nat_core.c            |  2 +-
net/nfc/core.c                         |  2 +-
25 files changed, 36 insertions(+), 36 deletions(-)