Skip to content

Power-well API implementation for Haswell

Wang Xingchao alsa-devel intel-gfx 7 versions – In review

Get series with b4
b4 am [email protected]

Versions newest first · linked by author and title

  1. v7 Latest4 patches 36 repliesIn review
  2. v64 patches 2 repliesSuperseded
  3. v54 patches 8 repliesSuperseded
Earlier versions · 4
VersionPostedPatchesRepliesStatus
v42 patches5 repliesSuperseded
v32 patches4 repliesSuperseded
v22 patches5 repliesSuperseded
v15 patches16 repliesSuperseded

Patches in v7 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/4ALSA: hda - Fix runtime PM checksound/pci/hda/hda_intel.c+8 -60 replies
2/4ALSA: hda - Move azx_first_init() into azx_probe_continue()sound/pci/hda/hda_intel.c+5 -80 replies
3/4ALSA: hda - Add power-welll support for haswell HDAsound/pci/hda/Kconfig sound/pci/hda/Makefile sound/pci/hda/hda_i915.c +2 more+179 -30 replies
4/4i915/drm: Add private api for power well usagedrivers/gpu/drm/i915/i915_dma.c drivers/gpu/drm/i915/i915_drv.h drivers/gpu/drm/i915/intel_drv.h +2 more+132 -70 replies

Reviews trailers per patch

3 of 4 patches have a Reviewed-by or Acked-by.

PatchTakashi IwaiRafael J. WysockiLiam GirdwoodDavid HenningssonDamien LespiauJesse Barnes
1/4R-b R-b
2/4
3/4R-b R-b R-b
4/4R-b R-b R-b

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes. Scroll the table sideways for all 6 reviewers.

Read the v7 thread

Cover letter [PATCH 0/4 V7] Power-well API implementation for Haswell

Hi all,

This is V7 and here're some changes notes:
change from V6-->V7:
- rename variable
- use HAS_POWER_WELL instead of IS_HASWELL
- put structure inside drm_i915_private
- use WARN_ON for global pointer check

change from V5-->V6:
- Remove duplication code in new introduced probe work
- move duplication code in azx_probe_continue
- remove unused #ifdef
- replace request_module with symbol_request
- replace spin_lock_irq with spin_lock_irqsave in gfx side
- other typo fixes
(review by Takashi)

change from V4-->V5:
- fix reference count bug
- new patch on general runtime pm support for audio pci device
- new patch to avoid request_module() deadlock

change between V3-->V4:
- add new structure i915_power_well
- initialize drm_device pointer at module init time
- change function name

change between V2-->V3:
- make SND_HDA_I915 selectable
- use snd_printdd to output message
- add return error code check
- use symbol_request to replace symbol_get
- release power_well at azx_free
- some typo fixes

changes between V1-->V2:
- use reference count to track power-well usage
- remove external module, compiled into snd-hda-intel instead
- manage symbols and module loading properly
- remove IS_HSW macro, use flag instead
- remove audio callback for gfx driver to avoid dependency
- split whole patch into two pieces for easy review
- more typo fixes

Takashi Iwai (1):
ALSA: hda - Move azx_first_init() into azx_probe_continue()

Wang Xingchao (3):
ALSA: hda - Fix runtime PM check
ALSA: hda - Add power-welll support for haswell HDA i915/drm: Add private api for power well usage

 drivers/gpu/drm/i915/i915_dma.c  |    6 +++
 drivers/gpu/drm/i915/i915_drv.h  |   12 ++++++
 drivers/gpu/drm/i915/intel_drv.h |    4 ++
 drivers/gpu/drm/i915/intel_pm.c  |   81 ++++++++++++++++++++++++++++++++---
 include/drm/i915_powerwell.h     |   36 ++++++++++++++++
 sound/pci/hda/Kconfig            |   10 +++++
 sound/pci/hda/Makefile           |    2 +
 sound/pci/hda/hda_i915.c         |   75 ++++++++++++++++++++++++++++++++
 sound/pci/hda/hda_i915.h         |   35 +++++++++++++++
 sound/pci/hda/hda_intel.c        |   87 ++++++++++++++++++++++++++++++--------
 10 files changed, 324 insertions(+), 24 deletions(-)
 create mode 100644 include/drm/i915_powerwell.h
 create mode 100644 sound/pci/hda/hda_i915.c
 create mode 100644 sound/pci/hda/hda_i915.h
Signature · 1 line
1.7.9.5