perf tools: Assorted fixes and changes on perf top/report
Get series with b4
b4 am [email protected]Versions newest first
- v1 Latest9 patches 8 repliesIn review
Patches in v1 No applies recorded yet
| # | Subject and files | Size | Replies | Applied |
|---|---|---|---|---|
| 1/9 | perf top: Fix -E option behaviortools/ | +5 | 1 reply | |
| 2/9 | perf top: Fix percent output when no samples collectedtools/ | +17 | 1 reply | |
| 3/9 | perf top: Get rid of *_threaded() functionstools/ tools/ tools/ | +19 | 1 reply | |
| 4/9 | perf hists: Move locking to its call-sitestools/ tools/ tools/ | +18 | 1 reply | |
| 5/9 | perf report: Don't be bothered with locking when adding hist entriestools/ | +0 | 1 reply | |
| 6/9 | perf report: Add --percent-limit optiontools/ tools/ tools/ +5 more | +115 | 0 replies | |
| 7/9 | perf top: Add --percent-limit optiontools/ tools/ tools/ +1 more | +34 | 0 replies | |
| 8/9 | perf report: Add report.percent-limit config variabletools/ | +6 | 3 replies | |
| 9/9 | perf top: Reuse report.percent-limit config variabletools/ | +15 | 0 replies |
Reviews trailers per patch
6 of 9 patches have a Reviewed-by or Acked-by.
| Patch | Pekka Enberg | Jiri Olsa |
|---|---|---|
| 1/9 | T-b | |
| 2/9 | T-b | |
| 3/9 | A-b | |
| 4/9 | A-b | |
| 5/9 | A-b | |
| 6/9 | A-b | |
| 7/9 | A-b | |
| 8/9 | A-b | |
| 9/9 |
Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes.
Cover letter [PATCHSET 0/9] perf tools: Assorted fixes and changes on perf top/report
Hi,
This patchset is a collection of 3 changes on perf top and report tools. I wanted to make them independent, but failed due to laziness. :)
Patch 1 is a fix for -E option handling in perf top. IIUC it only shows a given number of entries. Patch 2 is a simple fix.
Patch 3-5 remove a set of _threaded() functions and also remove unnecessary locking on perf report path. It leads to a small performance gain.
Patch 6-9 implement a long-requested --percent-limit option. I preserve the default value to 0 but an user can set it to a different value using the .perfconfig file.
You can get it from 'perf/top-v1' branch on my tree at:
git://git.kernel.org/pub/scm/linux/kernel/git/namhyung/linux-perf.git
Any comments are welcome, thanks.
Namhyung
Namhyung Kim (9):
perf top: Fix -E option behavior
perf top: Fix percent output when no samples collected perf top: Get rid of *_threaded() functions
perf hists: Move locking to its call-sites
perf report: Don't be bothered with locking when adding hist entries perf report: Add --percent-limit option
perf top: Add --percent-limit option
perf report: Add report.percent-limit config variable perf top: Reuse report.percent-limit config variable
tools/perf/Documentation/perf-report.txt | 4 ++ tools/perf/Documentation/perf-top.txt | 4 ++ tools/perf/builtin-diff.c | 2 +- tools/perf/builtin-report.c | 50 +++++++++++------ tools/perf/builtin-top.c | 73 ++++++++++++++++-------- tools/perf/ui/browsers/hists.c | 95 +++++++++++++++++++++++++++----- tools/perf/ui/gtk/hists.c | 13 ++++- tools/perf/ui/stdio/hist.c | 7 ++- tools/perf/util/hist.c | 50 +++-------------- tools/perf/util/hist.h | 14 ++--- tools/perf/util/top.c | 23 ++++++-- tools/perf/util/top.h | 1 + 12 files changed, 222 insertions(+), 114 deletions(-)
Signature · 1 line
1.7.11.7