fix the pci device malfunction if a wrong bus address is assigned by firmware
Status from this message: Applied to my "next" branch for v3.11, thanks.
Get series with b4
b4 am [email protected]Versions newest first · linked by author and title
- v2 Latest3 patches 4 repliesApplied
- v12 patches 9 repliesSuperseded
Changes in v2 from the cover letter
* Use the method suggested by Bjorn to check if we have a wrong bus address set in the PCI BAR register.
* Split the "move the pcibios_bus_to_resource() call out of the if/else wrap" change into a new patch.
* A minor new patch is introduced to add 0x prefix for the PCI BAR register position.
Patches in v2 Applied
| # | Subject and files | Size | Replies | Applied |
|---|---|---|---|---|
| 1/3 | PCI: add 0x prefix when printing the BAR registers position in __pci_read_basedrivers/ | +2 | 3 replies | |
| 2/3 | PCI: converge the unnecessary sprinkling of pcibios_bus_to_resource in __pci_read_basedrivers/ | +2 | 0 replies | |
| 3/3 | PCI: unset the resource if a wrong bus address is assigned by firmwaredrivers/ | +24 | 0 replies |
Reviews trailers per patch
No Reviewed-by, Acked-by or Tested-by trailers for v2 yet.
Cover letter [PATCH v2 0/3] fix the pci device malfunction if a wrong bus address is assigned by firmware
v2:
* Use the method suggested by Bjorn to check if we have a wrong bus address set in the PCI BAR register.
* Split the "move the pcibios_bus_to_resource() call out of the if/else wrap" change into a new patch.
* A minor new patch is introduced to add 0x prefix for the PCI BAR register position.
v1:
On a fsl p2020rdb-pc board, the onboard pci device is assigned the bus address 0xa0000000 by firmware. But the kernel allocate the cpu address 0xa0000000 ~ 0xbfffffff to this PCIe controller and use 0xe0000000 ~ 0xdfffffff as its bus address. In this case the kernel would think that the bus address in this pci device is correct and leave it unchanged. Then causes this device not work.
Even though this looks like a mismatch of the address space between firmware and kernel. I think we should detect this kind of error and fix it automatically if we don't want just to probe only (PCI_PROBE_ONLY is not set).
---
Kevin Hao (3):
PCI: add 0x prefix when printing the BAR registers position in
__pci_read_base
PCI: converge the unnecessary sprinkling of pcibios_bus_to_resource in
__pci_read_basePCI: unset the resource if a wrong bus address is assigned by firmware
drivers/pci/probe.c | 34 ++++++++++++++++++++++++++++------ 1 file changed, 28 insertions(+), 6 deletions(-)
Signature · 1 line
1.8.1.4