Skip to content

scsi_debug: bug fixes and cleanups for data integrity support

Akinobu Mita linux-scsi 3 versions – New

Get series with b4
b4 am [email protected]

Versions newest first · linked by author and title

  1. v4 Latest6 patches 0 repliesNew
  2. v36 patches 7 repliesSuperseded
  3. v25 patches 0 repliesSuperseded

Patches in v4 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/6scsi_debug: fix invalid address passed to kunmap_atomic()drivers/scsi/scsi_debug.c+6 -70 replies
2/6scsi_debug: fix incorrectly nested kmap_atomic()drivers/scsi/scsi_debug.c+3 -40 replies
3/6scsi_debug: fix NULL pointer dereference with parameters dif=0 dix=1drivers/scsi/scsi_debug.c+1 -10 replies
4/6scsi_debug: invalidate protection info for unmapped regiondrivers/scsi/scsi_debug.c+5 -00 replies
5/6scsi_debug: simplify offset calculation for dif_storepdrivers/scsi/scsi_debug.c+7 -110 replies
6/6scsi_debug: reduce duplication between prot_verify_read and prot_verify_writedrivers/scsi/scsi_debug.c+54 -850 replies

Reviews trailers per patch

All 6 patches have a Reviewed-by or Acked-by.

PatchDouglas GilbertMartin K. Petersen
1/6A-b A-b
2/6A-b A-b
3/6A-b A-b
4/6A-b A-b
5/6A-b A-b
6/6A-b A-b

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes.

Read the v4 thread

Cover letter [PATCH v4 0/6] scsi_debug: bug fixes and cleanups for data integrity support

Hi James,

Please consider to apply these patches to your tree. The only difference between v3 and v4 is adding Acked-by from Douglas and Martin.

This patch set includes bug fixes which I hit when I was tried testing the data integrity support in scsi_debug on x86_32.

And it also includes cleanups which helps increasing readability and further bug fixing in data integrity support.

* Changes from v3
- Add Acked-by lines

* Changes from v2
- Add new bug fix patch for UNMAP command support
- Change the way to fix for the patch "fix invalid address passed to kunmap_atomic()"
- Reduce more lines of code for the patch "reduce duplication between prot_verify_read and prot_verify_writ"

* Changes from v1
- Split the patch "fix data integrity support on highmem machine" into two separate patches.
- Add new cleanup patch "reduce duplication between prot_verify_read and prot_verify_write".

Cc "James E.J. Bottomley" <[email protected]>
Cc Douglas Gilbert <[email protected]>
Cc "Martin K. Petersen" <[email protected]>

Akinobu Mita (6):
scsi_debug: fix invalid address passed to kunmap_atomic()
scsi_debug: fix incorrectly nested kmap_atomic()
scsi_debug: fix NULL pointer dereference with parameters dif=0 dix=1
scsi_debug: invalidate protection info for unmapped region
scsi_debug: simplify offset calculation for dif_storep
scsi_debug: reduce duplication between prot_verify_read and
prot_verify_write

 drivers/scsi/scsi_debug.c | 176 +++++++++++++++++++---------------------------
 1 file changed, 72 insertions(+), 104 deletions(-)
Signature · 1 line
1.8.1.4