Skip to content

New FC timeout handler

Hannes Reinecke linux-scsi 1 version In review

Get series with b4
b4 am [email protected]

Versions newest first

  1. v1 Latest4 patches 9 repliesIn review

Patches in v1 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/4scsi: move initialization of scmd->eh_entrydrivers/scsi/scsi_lib.c+2 -22 replies
2/4blk-timeout: add BLK_EH_SCHEDULED return codedrivers/scsi/scsi_error.c include/linux/blkdev.h+4 -00 replies
3/4scsi: export functions for new fc timeout handlerdrivers/scsi/scsi_error.c drivers/scsi/scsi_lib.c drivers/scsi/scsi_priv.h+8 -10 replies
4/4scsi_transport_fc: FC timeout handlerdrivers/scsi/scsi_transport_fc.c include/scsi/scsi_transport_fc.h+64 -15 replies

Reviews trailers per patch

No Reviewed-by, Acked-by or Tested-by trailers for v1 yet.

Read the v1 thread

Cover letter [PATCH 0/4] New FC timeout handler

Hi all,

this is the first step towards a new FC error handler. This patch implements a new FC command timeout handler which will be sending command aborts inline without engaging SCSI EH.

In addition the commands will be returned directly if the command abort succeeded, cutting down recovery times dramatically.

With the original scsi error recovery I got:

# time dd if=/dev/zero of=/mnt/test.blk bs=512 count=2048 oflag=sync
2048+0 records in
2048+0 records out
1048576 bytes (1.0 MB) copied, 3.72732 s, 281 kB/s

real 2m14.475s
user 0m0.000s
sys 0m0.104s

with this patchset I got:

# time dd if=/dev/zero of=/mnt/test.blk bs=512 count=2048 oflag=sync
2048+0 records in
2048+0 records out
1048576 bytes (1.0 MB) copied, 79.6376 s, 13.2 kB/s

real 1m19.642s
user 0m0.000s
sys 0m0.100s

Test was to disable RSCN on the target port, disable the target port, and then start the 'dd' command as indicated.

Comments etc are welcome.

Hannes Reinecke (4):
scsi: move initialization of scmd->eh_entry
blk-timeout: add BLK_EH_SCHEDULED return code
scsi: export functions for new fc timeout handler
scsi_transport_fc: FC timeout handler

 drivers/scsi/scsi_error.c        |  8 ++++-
 drivers/scsi/scsi_lib.c          |  6 ++--
 drivers/scsi/scsi_priv.h         |  2 ++
 drivers/scsi/scsi_transport_fc.c | 63 +++++++++++++++++++++++++++++++++++++++-
 include/linux/blkdev.h           |  1 +
 include/scsi/scsi_transport_fc.h |  2 ++
 6 files changed, 78 insertions(+), 4 deletions(-)
Signature · 1 line
1.7.12.4