Skip to content

Haswell watermarks

Paulo Zanoni intel-gfx 1 version In review

Get series with b4
b4 am [email protected]

Versions newest first

  1. v1 Latest5 patches 11 repliesIn review

Patches in v1 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/5drm/i915: add "enable" argument to intel_update_sprite_watermarksdrivers/gpu/drm/i915/i915_drv.h drivers/gpu/drm/i915/intel_drv.h drivers/gpu/drm/i915/intel_pm.c +1 more+16 -81 reply
2/5drm/i915: add haswell_update_sprite_wmdrivers/gpu/drm/i915/intel_drv.h drivers/gpu/drm/i915/intel_pm.c+34 -12 replies
3/5drm/i915: properly set HSW WM_PIPE registersdrivers/gpu/drm/i915/i915_reg.h drivers/gpu/drm/i915/intel_pm.c+325 -183 replies
3/5drm/i915: properly set HSW WM_PIPE registersdrivers/gpu/drm/i915/i915_reg.h drivers/gpu/drm/i915/intel_pm.c+323 -180 replies
3/5drm/i915: properly set HSW WM_PIPE registersdrivers/gpu/drm/i915/i915_reg.h drivers/gpu/drm/i915/intel_pm.c+323 -183 replies
4/5drm/i915: properly set HSW WM_LP watermarksdrivers/gpu/drm/i915/i915_reg.h drivers/gpu/drm/i915/intel_pm.c+187 -111 reply
4/5drm/i915: properly set HSW WM_LP watermarksdrivers/gpu/drm/i915/i915_reg.h drivers/gpu/drm/i915/intel_pm.c+187 -186 replies
5/5drm/i915: add support for 5/6 data buffer partitioning on Haswelldrivers/gpu/drm/i915/intel_pm.c+53 -114 replies

Reviews trailers per patch

All 8 patches have a Reviewed-by or Acked-by.

PatchVille Syrjälä
1/5R-b
2/5R-b
3/5R-b R-b
3/5R-b R-b
3/5R-b R-b
4/5R-b
4/5R-b
5/5R-b

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes.

Read the v1 thread

Cover letter [PATCH 0/5] Haswell watermarks

From: Paulo Zanoni <[email protected]>

Hi

This series is a new version of "drm/i915: replace snb_update_wm with haswell_update_wm on HSW". Ville asked to split the series into smaller patches, so here they are. I also implemented the other suggestions made by Ville.

After this series, the only thing missing for correctness of the Haswell watermark register values will be to use the correct mode clock when calculating linetime watermarks. I had a patch for this, but Daniel suggested to wait until we merge "drm/i915: store adjust dotclock in adjustede_mode->clock". I can already see us reaching PC7 state with this series on eDP 1920x1080 with 138.78MHz pixel clock.

Thanks,
Paulo

Paulo Zanoni (5):
drm/i915: add "enable" argument to intel_update_sprite_watermarks drm/i915: add haswell_update_sprite_wm
drm/i915: properly set HSW WM_PIPE registers
drm/i915: properly set HSW WM_LP watermarks
drm/i915: add support for 5/6 data buffer partitioning on Haswell

 drivers/gpu/drm/i915/i915_drv.h     |   3 +-
 drivers/gpu/drm/i915/i915_reg.h     |   7 +
 drivers/gpu/drm/i915/intel_drv.h    |  14 +-
 drivers/gpu/drm/i915/intel_pm.c     | 588 ++++++++++++++++++++++++++++++++++--
 drivers/gpu/drm/i915/intel_sprite.c |   8 +-
 5 files changed, 593 insertions(+), 27 deletions(-)
Signature · 1 line
1.8.1.2