Skip to content

Make qemu-io commands available in the monitor

Kevin Wolf qemu-devel 2 versions – Applied

Status from this message: Thanks, applied to my block tree:

Get series with b4
b4 am [email protected]

Versions newest first · linked by author and title

  1. v2 Latest16 patches 2 repliesApplied
  2. v116 patches 28 repliesSuperseded

Changes in v2 from the cover letter

- Drop the QMP command, make it HMP only
- Minor review comments like typos

Patches in v2 Applied

#Subject and filesSizeRepliesApplied
1/16qemu-io: Remove unused args_commandcmd.c cmd.h qemu-io.c+2 -380 replies
2/16cutils: Support 'P' and 'E' suffixes in strtosz()include/qemu-common.h monitor.c qemu-img.c +2 more+20 -120 replies
3/16qemu-io: Make cvtnum() a wrapper around strtosz_suffix()cmd.c cmd.h qemu-io.c+6 -380 replies
4/16qemu-io: Handle cvtnum() errors in 'alloc'qemu-io.c+8 -10 replies
5/16qemu-io: Don't use global bs in command implementationscmd.c cmd.h qemu-io.c+101 -800 replies
6/16qemu-io: Split off commands to qemu-io-cmds.cMakefile qemu-io-cmds.c qemu-io.c+1838 -18160 replies
7/16qemu-io: Factor out qemuio_commandcmd.c cmd.h qemu-io-cmds.c+31 -390 replies
8/16qemu-io: Move 'help' functioncmd.c cmd.h qemu-io-cmds.c+66 -810 replies
9/16qemu-io: Move 'quit' functioncmd.c cmd.h qemu-io.c+16 -320 replies
10/16qemu-io: Move qemu_strsep() to cutils.ccmd.c include/qemu-common.h util/cutils.c+22 -210 replies
11/16qemu-io: Move functions for registering and running commandscmd.c cmd.h qemu-io-cmds.c +1 more+148 -1780 replies
12/16qemu-io: Move command_loop() and friendscmd.c cmd.h qemu-io.c+139 -1480 replies
13/16qemu-io: Move remaining helpers from cmd.cMakefile cmd.c cmd.h +1 more+105 -1540 replies
14/16qemu-io: Interface cleanupcmd.h include/qemu-io.h qemu-io-cmds.c +1 more+56 -590 replies
15/16qemu-io: Use the qemu version for -Vqemu-io.c+1 -30 replies
16/16Make qemu-io commands available in HMPMakefile Makefile.objs hmp-commands.hx +2 more+37 -11 reply

Reviews trailers per patch

11 of 16 patches have a Reviewed-by or Acked-by.

PatchEric Blake
1/16R-b
2/16R-b
3/16R-b
4/16R-b
5/16R-b
6/16R-b
7/16R-b
8/16R-b
9/16R-b
10/16R-b
11/16R-b
12/16
13/16
14/16
15/16
16/16

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes.

Read the v2 thread

Cover letter [Qemu-devel] [PATCH v2 00/16] Make qemu-io commands available in the monitor

This is a prerequisite for some kind of tests. It involves reorganising the qemu-io code so that the command part can be separated and doesn't pollute the global namespace any more, so we can link it with qemu.

v2:
- Drop the QMP command, make it HMP only
- Minor review comments like typos

Kevin Wolf (16):
qemu-io: Remove unused args_command
cutils: Support 'P' and 'E' suffixes in strtosz()
qemu-io: Make cvtnum() a wrapper around strtosz_suffix()
qemu-io: Handle cvtnum() errors in 'alloc'
qemu-io: Don't use global bs in command implementations
qemu-io: Split off commands to qemu-io-cmds.c
qemu-io: Factor out qemuio_command
qemu-io: Move 'help' function
qemu-io: Move 'quit' function
qemu-io: Move qemu_strsep() to cutils.c
qemu-io: Move functions for registering and running commands
qemu-io: Move command_loop() and friends
qemu-io: Move remaining helpers from cmd.c
qemu-io: Interface cleanup
qemu-io: Use the qemu version for -V
Make qemu-io commands available in HMP

 Makefile                   |    2 +-
 Makefile.objs              |    1 +
 cmd.c                      |  612 -------------
 cmd.h                      |   79 --
 hmp-commands.hx            |   16 +
 hmp.c                      |   18 +
 hmp.h                      |    1 +
 include/qemu-common.h      |    3 +
 include/qemu-io.h          |   46 +
 monitor.c                  |    8 +-
 qemu-img.c                 |   10 +-
 qemu-io-cmds.c             | 2118 ++++++++++++++++++++++++++++++++++++++++++++
 qemu-io.c                  | 1990 ++++-------------------------------------
 tests/qemu-iotests/049.out |    8 +-
 util/cutils.c              |   25 +
 15 files changed, 2416 insertions(+), 2521 deletions(-)
 delete mode 100644 cmd.c
 delete mode 100644 cmd.h
 create mode 100644 include/qemu-io.h
 create mode 100644 qemu-io-cmds.c
Signature · 1 line
1.8.1.4