Skip to content

brcmfmac: firmware-signalling fixes

Arend van Spriel linux-wireless 1 version In review

Get series with b4
b4 am [email protected]

Versions newest first

  1. v1 Latest16 patches 3 repliesIn review

Patches in v1 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/16brcmfmac: allow firmware-signal tlv to be longer than specifieddrivers/net/wireless/brcm80211/brcmfmac/fwsignal.c+1 -10 replies
2/16brcmfmac: remove fifo bitfield from brcmf_skbuff_cb::if_flagsdrivers/net/wireless/brcm80211/brcmfmac/fwsignal.c+3 -80 replies
3/16brcmfmac: Take bus flowcontrol at credit mgmt into account.drivers/net/wireless/brcm80211/brcmfmac/dhd.h drivers/net/wireless/brcm80211/brcmfmac/dhd_linux.c drivers/net/wireless/brcm80211/brcmfmac/dhd_sdio.c +3 more+40 -30 replies
4/16brcmfmac: rework credit pickup to assure consistent handlingdrivers/net/wireless/brcm80211/brcmfmac/fwsignal.c+13 -170 replies
5/16brcmfmac: explicitly indicate sk_buff is sent upon request creditdrivers/net/wireless/brcm80211/brcmfmac/fwsignal.c+53 -690 replies
6/16brcmfmac: reducing debug logging in firmware-signalling codedrivers/net/wireless/brcm80211/brcmfmac/dhd_linux.c drivers/net/wireless/brcm80211/brcmfmac/fwsignal.c+66 -620 replies
7/16brcmfmac: On bus flow control use fw signalling or netif.drivers/net/wireless/brcm80211/brcmfmac/dhd_linux.c+8 -50 replies
8/16brcmfmac: For FW signalling it is necessary to track gen bit.drivers/net/wireless/brcm80211/brcmfmac/fwsignal.c+29 -630 replies
9/16brcmfmac: Correct creditmap when credit borrowing is active.drivers/net/wireless/brcm80211/brcmfmac/fwsignal.c+7 -20 replies
10/16brcmfmac: Sent TIM information in case of data available.drivers/net/wireless/brcm80211/brcmfmac/fwsignal.c+103 -640 replies
11/16brcmfmac: Find correct MAC descriptor in case of TDLS.drivers/net/wireless/brcm80211/brcmfmac/fwsignal.c+6 -110 replies
12/16brcmfmac: fix invalid ifp lookup in firmware-signallingdrivers/net/wireless/brcm80211/brcmfmac/fwsignal.c+1 -10 replies
13/16brcmfmac: Accept only first creditmap event.drivers/net/wireless/brcm80211/brcmfmac/fwsignal.c+5 -00 replies
14/16brcmfmac: Signalling header push and pull on logic places.drivers/net/wireless/brcm80211/brcmfmac/fwsignal.c+13 -290 replies
15/16brcmfmac: Fix endless loop when brcmf_fws_commit_skb fails.drivers/net/wireless/brcm80211/brcmfmac/fwsignal.c+2 -10 replies
16/16brcmfmac: Simplify counting transit count.drivers/net/wireless/brcm80211/brcmfmac/fwsignal.c+12 -190 replies

Reviews trailers per patch

All 16 patches have a Reviewed-by or Acked-by.

PatchHante MeulemanPieter-Paul GiesbertsArend Van SprielFranky (Zhenhui) Lin
1/16R-b R-b
2/16R-b R-b
3/16R-b R-b R-b
4/16R-b R-b
5/16R-b R-b
6/16R-b R-b
7/16R-b
8/16R-b
9/16R-b
10/16R-b
11/16R-b
12/16R-b
13/16R-b
14/16R-b
15/16R-b
16/16R-b

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes. Scroll the table sideways for all 4 reviewers.

Read the v1 thread

Cover letter [PATCH for 3.10 00/16] brcmfmac: firmware-signalling fixes

This is a somewhat large series and reading the message of the announcement of v3.10-rc3 I think it is good to give our story up front. Firmware-signalling is a new feature merged in for 3.10, which was a major overhaul of the transmit path in brcmfmac. During and after the merge window we still have some blanks in our test coverage and further testing revealed issues with P2P, TDLS, and power-saving clients in AP mode. These issues have been fixed in this series.

As said this series is intended for 3.10 and applies to the master branch of the wireless repository.

Arend van Spriel (6):
brcmfmac: allow firmware-signal tlv to be longer than specified
brcmfmac: remove fifo bitfield from brcmf_skbuff_cb::if_flags
brcmfmac: rework credit pickup to assure consistent handling
brcmfmac: explicitly indicate sk_buff is sent upon request credit
brcmfmac: reducing debug logging in firmware-signalling code
brcmfmac: Sent TIM information in case of data available.

Hante Meuleman (10):
brcmfmac: Take bus flowcontrol at credit mgmt into account.
brcmfmac: On bus flow control use fw signalling or netif.
brcmfmac: For FW signalling it is necessary to track gen bit.
brcmfmac: Correct creditmap when credit borrowing is active.
brcmfmac: Find correct MAC descriptor in case of TDLS.
brcmfmac: fix invalid ifp lookup in firmware-signalling
brcmfmac: Accept only first creditmap event.
brcmfmac: Signalling header push and pull on logic places.
brcmfmac: Fix endless loop when brcmf_fws_commit_skb fails.
brcmfmac: Simplify counting transit count.

 drivers/net/wireless/brcm80211/brcmfmac/dhd.h      |    2 +
 .../net/wireless/brcm80211/brcmfmac/dhd_linux.c    |   21 +-
 drivers/net/wireless/brcm80211/brcmfmac/dhd_sdio.c |    2 +-
 drivers/net/wireless/brcm80211/brcmfmac/fwsignal.c |  639 ++++++++++----------
 drivers/net/wireless/brcm80211/brcmfmac/fwsignal.h |    1 +
 drivers/net/wireless/brcm80211/brcmfmac/usb.c      |    8 +
 6 files changed, 340 insertions(+), 333 deletions(-)
Signature · 1 line
1.7.10.4