Skip to content

drm/tilcdc: bug fixes, mode selection improvements

Darren Etheridge dri-devel 2 versions – In review

Get series with b4
b4 am [email protected]

Versions newest first · linked by author and title

  1. v2 Latest7 patches 3 repliesIn review
  2. v15 patches 1 replySuperseded

Changes in v2 from the cover letter

Fix typos in commit messages
Add a patch that enables runtime modesetting to work correctly Fix an issue where the slave encoder can initialize before the i2c
subsystem, resulting in no displays being configured.

Patches in v2 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/7drm/tilcdc: support pixel widths greater than 1024drivers/gpu/drm/tilcdc/tilcdc_crtc.c drivers/gpu/drm/tilcdc/tilcdc_regs.h+16 -00 replies
2/7drm/tilcdc: adding some more devicetree configDocumentation/devicetree/bindings/drm/tilcdc/tilcdc.txt drivers/gpu/drm/tilcdc/tilcdc_crtc.c drivers/gpu/drm/tilcdc/tilcdc_drv.c +1 more+65 -30 replies
3/7drm/tilcdc: fixing off by one errors found on analyzerdrivers/gpu/drm/tilcdc/tilcdc_crtc.c+12 -70 replies
4/7drm/tilcdc: adding more guards to prevent selection of invalid modesdrivers/gpu/drm/tilcdc/tilcdc_crtc.c+46 -00 replies
5/7drm/tilcdc: whitespace fixes and tidyupdrivers/gpu/drm/tilcdc/tilcdc_crtc.c+10 -60 replies
6/7drm/tilcdc fixing i2c/slave initialization racedrivers/gpu/drm/tilcdc/tilcdc_drv.c drivers/gpu/drm/tilcdc/tilcdc_drv.h drivers/gpu/drm/tilcdc/tilcdc_slave.c+40 -250 replies
7/7drm/tilcdc: Clear bits of register we're going to set.drivers/gpu/drm/tilcdc/tilcdc_crtc.c+2 -00 replies

Reviews trailers per patch

None of the 7 patches has a Reviewed-by or Acked-by of their own; the series has one for all of them.

PatchRob Clark
SeriesA-b
1/7
2/7
3/7
4/7
5/7
6/7
7/7

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes.

Read the v2 thread

Cover letter [PATCH V2 0/7] drm/tilcdc: bug fixes, mode selection improvements

The series of patches that follow are intended to address issues that have been found in the tilcdc drm driver. The patchset enables support for screen resolutions with horizontal resolutions greater than 1024 pixels. The patchset also addresses a limitation where certain monitor timings would overflow LCD controller timing registers causing either no monitor signal or a very corrupted display. This patchset will stop monitor modes from being reported as valid if the lcd controller cannot support them.

V2:
Fix typos in commit messages
Add a patch that enables runtime modesetting to work correctly Fix an issue where the slave encoder can initialize before the i2c
subsystem, resulting in no displays being configured.

Applies cleanly on drm-next.

Darren Etheridge (6):
drm/tilcdc: support pixel widths greater than 1024 drm/tilcdc: adding some more devicetree config drm/tilcdc: fixing off by one errors found on analyzer drm/tilcdc: adding more guards to prevent selection of invalid modes drm/tilcdc: whitespace fixes and tidyup
drm/tilcdc fixing i2c/slave initialization race

Pantelis Antoniou (1):
drm/tilcdc: Clear bits of register we're going to set.

 .../devicetree/bindings/drm/tilcdc/tilcdc.txt      |    8 ++
 drivers/gpu/drm/tilcdc/tilcdc_crtc.c               |  117 +++++++++++++++++--
 drivers/gpu/drm/tilcdc/tilcdc_drv.c                |   25 ++++-
 drivers/gpu/drm/tilcdc/tilcdc_drv.h                |   24 ++++-
 drivers/gpu/drm/tilcdc/tilcdc_regs.h               |    1 +
 drivers/gpu/drm/tilcdc/tilcdc_slave.c              |   53 +++++----
 6 files changed, 189 insertions(+), 39 deletions(-)