Skip to content

drivers/gpio: Altera soft IP GPIO driver

[email protected] linux-devicetree linux-gpio lkml 9 versions – In review

Get series with b4
b4 am [email protected]

Versions newest first · linked by author and title

  1. v10 Latest2 patches 1 replyIn review
  2. v92 patches 2 repliesSuperseded
  3. v82 patches 8 repliesSuperseded
Earlier versions · 6
VersionPostedPatchesRepliesStatus
v71 patch14 repliesSuperseded
v61 patch7 repliesSuperseded
v51 patch3 repliesSuperseded
v41 patch6 repliesSuperseded
v31 patch3 repliesSuperseded
v11 patch4 repliesSuperseded

Changes in v10 from the cover letter

Updated conflicting device tree parameters
Removed unused headers
Used macro instead of magic numbers for ngpio
Code readability cleanup using ?: and temporal variables
Removed leftover garbage and unnecessary function calls
Checked bgpio_init but unusable because Altera GPIO may not be a multiple of 8 bits

Patches in v10 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/2drivers/gpio: Altera soft IP GPIO driver device tree bindingDocumentation/devicetree/bindings/gpio/gpio-altera.txt+43 -00 replies
2/2drivers/gpio: Altera soft IP GPIO driverMAINTAINERS drivers/gpio/Kconfig drivers/gpio/Makefile +1 more+391 -00 replies

Reviews trailers per patch

No Reviewed-by, Acked-by or Tested-by trailers for v10 yet.

Read the v10 thread

Cover letter [PATCH v10 0/2] drivers/gpio: Altera soft IP GPIO driver

From: Tien Hock Loh <[email protected]>

Adds a new device tree binding and driver for Altera soft GPIO IP. The driver is able to do read/write and allows GPIO to be a interrupt controller.

Tested on Altera GHRD on interrupt handling and IO.

v10:
Updated conflicting device tree parameters
Removed unused headers
Used macro instead of magic numbers for ngpio
Code readability cleanup using ?: and temporal variables
Removed leftover garbage and unnecessary function calls
Checked bgpio_init but unusable because Altera GPIO may not be a multiple of 8 bits

v9:
Removed duplicated initialization on set_type using temporals to improve code readability in calling generic_handle_irq Using ?: ternary to reduce code size

v8:
Using for_each_set_bit
added const for struct definition
removed naggy pr_err
sort alpha header
remove unused macros
use fixed width data types instead of unsigned long whitespace issue fixes removed _relaxed function for better compatibility across different CPU changed irq_create_mapping to platform_get_irq updated implementation to use gpiochip_irqchip_add reserve interrupt-cells number 2 in device tree binding for future use remove confusing sections on devicetree bindings Added tristate Kconfig help text

v7:
used dev_warn instead of pr_warn
clean up unnecesarry if else indentation

v6:
Added irq_startup and irq_shutdown
changed bitwise clamping style
cleanup bitwise operation to improve readability change naming of mapped irqs from virq to mapped_irq

v5:
dispose irq_domain mapping correctly
update optional binding description in binding docs

v4:
added vendor prefix to devicetree binding for IP specific properties using MMIO GPIO helper library instead of manually map PIO to memory altera_gpio_chip inline struct documentation to kerneldoc using dev_ print to print a better failure message

v2, v3:
Do not reference NO_IRQ
Updated irq_set_type to only allow the hardware configured irq type

Tien Hock Loh (2):
drivers/gpio: Altera soft IP GPIO driver device tree binding drivers/gpio: Altera soft IP GPIO driver

 .../devicetree/bindings/gpio/gpio-altera.txt       |  43 +++
 MAINTAINERS                                        |   6 +
 drivers/gpio/Kconfig                               |  10 +
 drivers/gpio/Makefile                              |   1 +
 drivers/gpio/gpio-altera.c                         | 374 +++++++++++++++++++++
 5 files changed, 434 insertions(+)
 create mode 100644 Documentation/devicetree/bindings/gpio/gpio-altera.txt
 create mode 100644 drivers/gpio/gpio-altera.c
Signature · 1 line
1.7.11.GIT