Skip to content

brcmfmac: firmware-signalling fixes and cleanup

Arend van Spriel linux-wireless 1 version In review

Get series with b4
b4 am [email protected]

Versions newest first

  1. v1 Latest22 patches 2 repliesIn review

Patches in v1 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/22brcmfmac: allow firmware-signal tlv to be longer than specifieddrivers/net/wireless/brcm80211/brcmfmac/fwsignal.c+1 -10 replies
2/22brcmfmac: remove fifo bitfield from brcmf_skbuff_cb::if_flagsdrivers/net/wireless/brcm80211/brcmfmac/fwsignal.c+3 -80 replies
3/22brcmfmac: Take bus flowcontrol at credit mgmt into account.drivers/net/wireless/brcm80211/brcmfmac/dhd.h drivers/net/wireless/brcm80211/brcmfmac/dhd_linux.c drivers/net/wireless/brcm80211/brcmfmac/dhd_sdio.c +3 more+39 -30 replies
4/22brcmfmac: rework credit pickup to assure consistent handlingdrivers/net/wireless/brcm80211/brcmfmac/fwsignal.c+13 -170 replies
5/22brcmfmac: explicitly indicate sk_buff is sent upon request creditdrivers/net/wireless/brcm80211/brcmfmac/fwsignal.c+53 -690 replies
6/22brcmfmac: reducing debug logging in firmware-signalling codedrivers/net/wireless/brcm80211/brcmfmac/dhd_linux.c drivers/net/wireless/brcm80211/brcmfmac/fwsignal.c+66 -620 replies
7/22brcmfmac: On bus flow control use fw signalling or netif.drivers/net/wireless/brcm80211/brcmfmac/dhd_linux.c+8 -50 replies
8/22brcmfmac: For FW signalling it is necessary to track gen bit.drivers/net/wireless/brcm80211/brcmfmac/fwsignal.c+29 -630 replies
9/22brcmfmac: Correct creditmap when credit borrowing is active.drivers/net/wireless/brcm80211/brcmfmac/fwsignal.c+7 -20 replies
10/22brcmfmac: Sent TIM information in case of data available.drivers/net/wireless/brcm80211/brcmfmac/fwsignal.c+103 -640 replies
11/22brcmfmac: Find correct MAC descriptor in case of TDLS.drivers/net/wireless/brcm80211/brcmfmac/fwsignal.c+6 -110 replies
12/22brcmfmac: fix invalid ifp lookup in firmware-signallingdrivers/net/wireless/brcm80211/brcmfmac/fwsignal.c+1 -10 replies
13/22brcmfmac: Accept only first creditmap event.drivers/net/wireless/brcm80211/brcmfmac/fwsignal.c+5 -00 replies
14/22brcmfmac: Signalling header push and pull on logic places.drivers/net/wireless/brcm80211/brcmfmac/fwsignal.c+13 -290 replies
15/22brcmfmac: Fix endless loop when brcmf_fws_commit_skb fails.drivers/net/wireless/brcm80211/brcmfmac/fwsignal.c+2 -10 replies
16/22brcmfmac: Simplify counting transit count.drivers/net/wireless/brcm80211/brcmfmac/fwsignal.c+12 -190 replies
17/22brcmfmac: fix send_pkts statistic counter in firmware-signallingdrivers/net/wireless/brcm80211/brcmfmac/fwsignal.c+2 -30 replies
18/22brcmfmac: Always use fifo_credits, also for requested credits.drivers/net/wireless/brcm80211/brcmfmac/dhd_dbg.c drivers/net/wireless/brcm80211/brcmfmac/dhd_dbg.h drivers/net/wireless/brcm80211/brcmfmac/fwsignal.c+79 -970 replies
19/22brcmfmac: use credit mechanism for BC/MC if support by firmwaredrivers/net/wireless/brcm80211/brcmfmac/fweh.h drivers/net/wireless/brcm80211/brcmfmac/fwsignal.c+32 -20 replies
20/22brcmfmac: add trace event for capturing BDC headerdrivers/net/wireless/brcm80211/brcmfmac/dhd_cdc.c drivers/net/wireless/brcm80211/brcmfmac/tracepoint.h+24 -00 replies
21/22brcmfmac: increment hard_header_len instead of overridingdrivers/net/wireless/brcm80211/brcmfmac/dhd_linux.c+1 -10 replies
22/22brcmfmac: add debugfs statistics for firmware-signallingdrivers/net/wireless/brcm80211/brcmfmac/dhd_dbg.c drivers/net/wireless/brcm80211/brcmfmac/dhd_dbg.h drivers/net/wireless/brcm80211/brcmfmac/fwsignal.c+19 -50 replies

Reviews trailers per patch

All 22 patches have a Reviewed-by or Acked-by.

PatchArend Van SprielHante MeulemanPieter-Paul GiesbertsFranky (Zhenhui) Lin
1/22R-b R-b
2/22R-b R-b
3/22R-b R-b R-b
4/22R-b R-b
5/22R-b R-b
6/22R-b R-b
7/22R-b
8/22R-b
9/22R-b
10/22R-b
11/22R-b
12/22R-b
13/22R-b
14/22R-b
15/22R-b
16/22R-b
17/22R-b R-b
18/22R-b
19/22R-b R-b
20/22R-b R-b
21/22R-b
22/22R-b R-b

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes. Scroll the table sideways for all 4 reviewers.

Read the v1 thread

Cover letter [PATCH 00/22] brcmfmac: firmware-signalling fixes and cleanup

This series is intended for v3.11 and resolves a number of issues observed testing firmware-signalling feature with power-save stations and P2P scenarios as well as several patches for code cleanup.

The series applies to the master branch of the wireless-next repository.

Arend van Spriel (11):
brcmfmac: allow firmware-signal tlv to be longer than specified
brcmfmac: remove fifo bitfield from brcmf_skbuff_cb::if_flags
brcmfmac: rework credit pickup to assure consistent handling
brcmfmac: explicitly indicate sk_buff is sent upon request credit
brcmfmac: reducing debug logging in firmware-signalling code
brcmfmac: Sent TIM information in case of data available.
brcmfmac: fix send_pkts statistic counter in firmware-signalling
brcmfmac: use credit mechanism for BC/MC if support by firmware
brcmfmac: add trace event for capturing BDC header
brcmfmac: increment hard_header_len instead of overriding
brcmfmac: add debugfs statistics for firmware-signalling

Hante Meuleman (11):
brcmfmac: Take bus flowcontrol at credit mgmt into account.
brcmfmac: On bus flow control use fw signalling or netif.
brcmfmac: For FW signalling it is necessary to track gen bit.
brcmfmac: Correct creditmap when credit borrowing is active.
brcmfmac: Find correct MAC descriptor in case of TDLS.
brcmfmac: fix invalid ifp lookup in firmware-signalling
brcmfmac: Accept only first creditmap event.
brcmfmac: Signalling header push and pull on logic places.
brcmfmac: Fix endless loop when brcmf_fws_commit_skb fails.
brcmfmac: Simplify counting transit count.
brcmfmac: Always use fifo_credits, also for requested credits.

 drivers/net/wireless/brcm80211/brcmfmac/dhd.h      |    2 +
 drivers/net/wireless/brcm80211/brcmfmac/dhd_cdc.c  |    3 +
 drivers/net/wireless/brcm80211/brcmfmac/dhd_dbg.c  |   18 +-
 drivers/net/wireless/brcm80211/brcmfmac/dhd_dbg.h  |    6 +-
 .../net/wireless/brcm80211/brcmfmac/dhd_linux.c    |   23 +-
 drivers/net/wireless/brcm80211/brcmfmac/dhd_sdio.c |    2 +-
 drivers/net/wireless/brcm80211/brcmfmac/fweh.h     |    3 +-
 drivers/net/wireless/brcm80211/brcmfmac/fwsignal.c |  730 ++++++++++----------
 drivers/net/wireless/brcm80211/brcmfmac/fwsignal.h |    1 +
 .../net/wireless/brcm80211/brcmfmac/tracepoint.h   |   21 +
 drivers/net/wireless/brcm80211/brcmfmac/usb.c      |    8 +
 11 files changed, 436 insertions(+), 381 deletions(-)
Signature · 1 line
1.7.10.4