ARM: OMAP5: fix build breakage due to SCU usage
Get series with b4
b4 am [email protected]Versions newest first
- v1 Latest2 patches 2 repliesIn review
Patches in v1 No applies recorded yet
| # | Subject and files | Size | Replies | Applied |
|---|---|---|---|---|
| 1/2 | ARM: OMAP4: sleep: build OMAP4 specific functions only for OMAP4arch/ | +5 | 0 replies | |
| 2/2 | ARM: scu: provide inline dummy functions when SCU is not presentarch/ | +12 | 0 replies |
Reviews trailers per patch
All 2 patches have a Reviewed-by or Acked-by.
| Patch | Santosh Shilimkar |
|---|---|
| 1/2 | A-b |
| 2/2 | A-b |
Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes.
Cover letter [-next PATCH 0/2] ARM: OMAP5: fix build breakage due to SCU usage
Hi,
Cortex-A15 based OMAP5 does not use Snoop Control Unit(SCU)[1]. However, there is lot of code that is shared between Cortex-A9 based OMAP4 and OMAP5, hence functionality code is shared with runtime usage of SCU based on SoC worked on. However on building with OMAP5 only generates the following errors:arch/arm/mach-omap2/built-in.o: In function `scu_gp_set':arch/arm/mach-omap2/sleep44xx.S:132: undefined reference to scu_power_mode' arch/arm/mach-omap2/built-in.o: In function scu_gp_clear':arch/arm/mach-omap2/sleep44xx.S:229: undefined reference to scu_power_mode' arch/arm/mach-omap2/built-in.o: In function omap4_smp_init_cpus':arch/arm/mach-omap2/omap-smp.c:185: undefined reference to scu_get_core_count' arch/arm/mach-omap2/built-in.o: In function omap4_smp_prepare_cpus':arch/arm/mach-omap2/omap-smp.c:211: undefined reference to `scu_enable'
This was attempted to be "fixed" in various attempts in the past [2] [3].
This series applies on top of the other fixes in discussion for linux-next [4] [5].
Based on:git://git.kernel.org/pub/scm/linux/kernel/git/next/linux-next.git next-20130626
Nishanth Menon (2):
ARM: OMAP4: sleep: build OMAP4 specific functions only for OMAP4
ARM: scu: provide inline dummy functions when SCU is not present
arch/arm/include/asm/smp_scu.h | 13 ++++++++++++- arch/arm/mach-omap2/sleep44xx.S | 6 +++++- 2 files changed, 17 insertions(+), 2 deletions(-)
[1] http://infocenter.arm.com/help/index.jsp?topic=/com.arm.doc.ddi0407e/CHDFJICC.html
[2] https://patchwork.kernel.org/patch/2568091/
[3] http://marc.info/?t=137120115400001&r=1&w=2
[4] http://lists.infradead.org/pipermail/linux-arm-kernel/2013-June/178209.html
[5] https://patchwork.kernel.org/patch/2781471/
Regards,
Nishanth Menon
Signature · 1 line
1.7.9.5