Skip to content

minor improvements for ACPI dock and acpiphp drivers

Jiang Liu linux-acpi linux-pci lkml 2 versions – In review

Get series with b4
b4 am [email protected]

Versions newest first · linked by author and title

  1. v3 Latest10 patches 3 repliesIn review
  2. v29 patches 4 repliesSuperseded

Changes in v3 from the cover letter

The first four patches are the same as previous version and rework all other patches according to review comments.

Patches in v3 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/10ACPI, DOCK: avoid initializing acpi_dock_notifier_list multiple timesdrivers/acpi/dock.c+1 -10 replies
2/10ACPI, DOCK: kill redundant spin lock in dock station objectdrivers/acpi/dock.c+3 -120 replies
3/10ACPI, DOCK: mark initialization functions with __initdrivers/acpi/dock.c+6 -60 replies
4/10ACPI, DOCK: simplify implementation of dock_create_acpi_device()drivers/acpi/dock.c+1 -60 replies
5/10ACPI: introduce helper function acpi_has_method()drivers/acpi/battery.c drivers/acpi/ec.c drivers/acpi/processor_perflib.c +6 more+80 -1360 replies
6/10ACPI: introduce helper function acpi_execute_simple_method()drivers/acpi/battery.c drivers/acpi/bus.c drivers/acpi/power.c +5 more+29 -450 replies
7/10ACPI: introduce two helper functions to simplify codedrivers/acpi/scan.c drivers/acpi/utils.c include/acpi/acpi_bus.h+51 -250 replies
8/10ACPI: change acpi_[bay|dock]_match() in scan.c as global functionsdrivers/acpi/scan.c include/acpi/acpi_bus.h+39 -410 replies
9/10ACPI: simplify dock driver with new helper functionsdrivers/acpi/dock.c+12 -1100 replies
10/10ACPI: simplify acpiphp driver with new helper functionsdrivers/pci/hotplug/acpiphp_glue.c+8 -222 replies

Reviews trailers per patch

1 of 10 patches has a Reviewed-by or Acked-by.

PatchBjorn Helgaas
1/10
2/10
3/10
4/10
5/10
6/10
7/10
8/10
9/10
10/10A-b

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes.

Read the v3 thread

Cover letter [PATCH v3 00/10] minor improvements for ACPI dock and acpiphp drivers

From: Jiang Liu <[email protected]>

This is an following up patchset of "[PATCH 0/3] ACPI / dock / PCI: Fix problems with dock and PCI hotplug" with minor code cleanups and refinements. It applies to
git://git.kernel.org/pub/scm/linux/kernel/git/rafael/linux-pm.git linux-next

Due to hardware resource limitation, I have only done compilation and boot tests.

V2->V3:
The first four patches are the same as previous version and rework all other patches according to review comments.

Jiang Liu (10):
ACPI, DOCK: avoid initializing acpi_dock_notifier_list multiple times ACPI, DOCK: kill redundant spin lock in dock station object ACPI, DOCK: mark initialization functions with __init ACPI, DOCK: simplify implementation of dock_create_acpi_device()
ACPI: introduce helper function acpi_has_method()
ACPI: introduce helper function acpi_execute_simple_method()
ACPI: introduce two helper functions to simplify code
ACPI: change acpi_[bay|dock]_match() in scan.c as global functions
ACPI: simplify dock driver with new helper functions
ACPI: simplify acpiphp driver with new helper functions

 drivers/acpi/battery.c             |  19 +---
 drivers/acpi/bus.c                 |   6 +-
 drivers/acpi/dock.c                | 152 ++++-------------------------
 drivers/acpi/ec.c                  |   4 +-
 drivers/acpi/power.c               |   4 +-
 drivers/acpi/processor_perflib.c   |  22 ++---
 drivers/acpi/resource.c            |   4 +-
 drivers/acpi/scan.c                | 189 +++++++++++++------------------------
 drivers/acpi/sleep.c               |   7 +-
 drivers/acpi/thermal.c             |  18 +---
 drivers/acpi/utils.c               |  70 ++++++++++++++
 drivers/acpi/video.c               |  56 ++++-------
 drivers/acpi/video_detect.c        |  19 ++--
 drivers/pci/hotplug/acpiphp_glue.c |  30 ++----
 include/acpi/acpi_bus.h            |  10 ++
 15 files changed, 218 insertions(+), 392 deletions(-)
Signature · 1 line
1.8.1.2