usb: Add support for EHSET
Get series with b4
b4 am [email protected]Versions newest first
- v1 Latest2 patches 16 repliesIn review
Patches in v1 No applies recorded yet
| # | Subject and files | Size | Replies | Applied |
|---|---|---|---|---|
| 1/2 | usb: misc: EHSET Test Fixture device driver for host compliancedrivers/ drivers/ drivers/ | +148 | 0 replies | |
| 2/2 | usb: ehci: Add support for SINGLE_STEP_SET_FEATURE test of EHSETdrivers/ drivers/ drivers/ | +263 | 20 replies |
Reviews trailers per patch
1 of 2 patches has a Reviewed-by or Acked-by.
| Patch | Alan Stern |
|---|---|
| 1/2 | |
| 2/2 | A-b A-b |
Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes.
Cover letter [PATCH 0/2] usb: Add support for EHSET
PATCH 1/2 is a device driver supporting the Embedded Host High-Speed Electrical Test (EHSET) test fixture. This driver supports the set of VID/PIDs specified in the EHSET and activates the various test (TEST_J, TEST_K, et al) modes by issuing a USB_PORT_FEAT_TEST SetFeature request to the hub, or by directly toggling USB_PORT_FEAT_SUSPEND, in the case of the port suspend test.
In RFC/PATCH 2/2 *[1] the SINGLE_STEP_SET_FEATURE test is implemented. The fixture driver designates test selector=6 and sends the USB_PORT_FEAT_TEST request directly to the root hub. The EHCI hub driver is expected to handle this by calling functions in the queue driver to submit separate QTDs for the SETUP and DATA/STATUS stages of a GetDescriptor request, in essence duplicating the work of ehci_urb_enqueue(), but with the requisite added delay.
Quoted 3 lines · Alan Stern
It does sound like a lot of mucking around inside ehci-hcd for a relatively small benefit. But if people want it, I guess it can be added.
Thus this patch is an RFC because I'm pretty sure this method of "mucking around" isn't gonna sit well with most folks. So any alternative suggestions are welcome.
*[1] This second patch is mostly unmodified from the original commit made on the out-of-tree MSM kernel, so please excuse trivial style inconsistencies:
https://www.codeaurora.org/cgit/quic/la/kernel/msm/commit?id=c2084930fd49f04571627be0762ff40e5c5d90d8
Manu Gautam (2):
usb: misc: EHSET Test Fixture device driver for host compliance
usb: ehci: Add support for SINGLE_STEP_SET_FEATURE test of EHSET
drivers/usb/host/ehci-hub.c | 144 ++++++++++++++++++++++++++++++++++++++++- drivers/usb/host/ehci-q.c | 101 ++++++++++++++++++++++++++++ drivers/usb/misc/Kconfig | 13 ++++ drivers/usb/misc/Makefile | 1 + drivers/usb/misc/ehset.c | 152 +++++++++++++++++++++++++++++++++++++++++++ 5 files changed, 410 insertions(+), 1 deletions(-) create mode 100644 drivers/usb/misc/ehset.c
Signature · 2 lines
The Qualcomm Innovation Center, Inc. is a member of Code Aurora Forum, hosted by The Linux Foundation