Skip to content

Fail migration on bdrv_flush_all() error

Kevin Wolf qemu-devel 1 version In review

Get series with b4
b4 am [email protected]

Versions newest first

  1. v1 Latest3 patches 2 repliesIn review

Patches in v1 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/3block: Add return value for bdrv_flush_all()block.c include/block/block.h+9 -30 replies
2/3cpus: Add return value for vm_stop()cpus.c include/sysemu/sysemu.h stubs/vm-stop.c+16 -101 reply
3/3migration: Fail migration on bdrv_flush_all() errormigration.c+14 -30 replies

Reviews trailers per patch

None of the 3 patches has a Reviewed-by or Acked-by of their own; the series has one for all of them.

PatchStefan Hajnoczi
SeriesR-b
1/3
2/3
3/3

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes.

Read the v1 thread

Cover letter [Qemu-devel] [PATCH 0/3] Fail migration on bdrv_flush_all() error

If bdrv_flush_all() returns an error, there is an inconsistency in the view of an image file between the source and the destination host. Completing the migration would lead to corruption. Better abort migration in this case.

Kevin Wolf (3):
block: Add return value for bdrv_flush_all()
cpus: Add return value for vm_stop()
migration: Fail migration on bdrv_flush_all() error

 block.c                 | 10 ++++++++--
 cpus.c                  | 20 +++++++++++++-------
 include/block/block.h   |  2 +-
 include/sysemu/sysemu.h |  4 ++--
 migration.c             | 17 ++++++++++++++---
 stubs/vm-stop.c         |  2 +-
 6 files changed, 39 insertions(+), 16 deletions(-)
Signature · 1 line
1.8.1.4