Skip to content

HSW/LPT clocking code additional sequences

Paulo Zanoni intel-gfx 1 version Applied

Status from this message: I've merged the first three patches in this series to dinq, thanks for

Get series with b4
b4 am [email protected]

Versions newest first

  1. v1 Latest7 patches 14 repliesApplied

Patches in v1 Applied

#Subject and filesSizeRepliesApplied
1/7drm/i915: remove SDV support from lpt_pch_init_refclkdrivers/gpu/drm/i915/intel_display.c+34 -701 reply
2/7drm/i915: extract FDI mPHY functions from lpt_init_pch_refclkdrivers/gpu/drm/i915/intel_display.c+44 -310 replies
2/7drm/i915: extract FDI mPHY functions from lpt_init_pch_refclkdrivers/gpu/drm/i915/intel_display.c+45 -340 replies
3/7drm/i915: extract lpt_enable_clkout_dp from lpt_init_pch_refclkdrivers/gpu/drm/i915/intel_display.c+22 -161 reply
4/7drm/i915: extend lpt_enable_clkout_dpdrivers/gpu/drm/i915/i915_reg.h drivers/gpu/drm/i915/intel_display.c+31 -123 replies
5/7drm/i915: disable CLKOUT_DP when it's not neededdrivers/gpu/drm/i915/intel_display.c+34 -44 replies
6/7drm/i915: add functions to disable and restore LCPLLdrivers/gpu/drm/i915/i915_reg.h drivers/gpu/drm/i915/intel_display.c drivers/gpu/drm/i915/intel_drv.h+105 -08 replies
6/7drm/i915: add functions to disable and restore LCPLLdrivers/gpu/drm/i915/i915_reg.h drivers/gpu/drm/i915/intel_display.c drivers/gpu/drm/i915/intel_drv.h+102 -00 replies
7/7drm/i915: add some assertions to hsw_disable_lcplldrivers/gpu/drm/i915/i915_reg.h drivers/gpu/drm/i915/intel_display.c+36 -02 replies

Reviews trailers per patch

3 of 9 patches have a Reviewed-by or Acked-by of their own; the series has one for all of them.

PatchBen Widawsky
SeriesR-b
1/7R-b
2/7
2/7
3/7
4/7
5/7
6/7R-b R-b
6/7R-b R-b
7/7

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes.

Read the v1 thread

Cover letter [PATCH 0/7] HSW/LPT clocking code additional sequences

From: Paulo Zanoni <[email protected]>

Hi

On the code that allows Package C8+ we need to disable/reenable the PCH reference clocks and also disable/reenable LCPLL. This series implements the sequences that are going to be needed. I have local patches that use this code and they seem to work (we survive going to C10 and back to C7), and I also sent earlier versions of these patches to the mailing list, so open-source code that uses these functions already exists on the intel-gfx mailing list. The goal here is allow people to review/merge this while the final PC8+ patches are not yet 100% reviewer-compliant.

On the first 3 patches we massage our code so we can reuse it for PC8+ code. On patch 4 we extend the current code to also implement one of the sequences required by PC8+. On patch 5 we implement the equivalent disable sequence, also needed by PC8+. On patch 6 we implement the functions to disable and restore LCPLL, and on patch 7 we add some assertions that are going to be used.

If you want to review patches 1-3 all you need is C experience. For patches 4 and 5 you need to read the "Display iCLK programming" chapter of BSpec. For patches 6 and 7 you need to read "Display sequences for LCPLL disabling" and "Display sequences for Package C8".

Cheers,
Paulo

Paulo Zanoni (7):
drm/i915: remove SDV support from lpt_pch_init_refclk drm/i915: extract FDI mPHY functions from lpt_init_pch_refclk drm/i915: extract lpt_enable_clkout_dp from lpt_init_pch_refclk drm/i915: extend lpt_enable_clkout_dp
drm/i915: disable CLKOUT_DP when it's not needed drm/i915: add functions to disable and restore LCPLL drm/i915: add some assertions to hsw_disable_lcpll

 drivers/gpu/drm/i915/i915_reg.h      |  17 ++
 drivers/gpu/drm/i915/intel_display.c | 359 +++++++++++++++++++++++++----------
 drivers/gpu/drm/i915/intel_drv.h     |   3 +
 3 files changed, 276 insertions(+), 103 deletions(-)
Signature · 1 line
1.8.1.2