Skip to content

SLES resync

Hannes Reinecke dm-devel 1 version In review

Get series with b4
b4 am [email protected]

Versions newest first

  1. v1 Latest29 patches 4 repliesIn review

Patches in v1 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/29multipath: bind lifetime of udev context to main threadlibmpathpersist/mpath_persist.c libmpathpersist/mpath_persist.h libmpathpersist/mpath_pr_ioctl.c +5 more+35 -240 replies
2/29Document 'infinity' as possible value for dev_loss_tmomultipath.conf.annotated+2 -10 replies
3/29alua: Do not add preferred path priority for active/optimizedlibmultipath/prioritizers/alua.c+1 -10 replies
4/29multipath: Increase dev_loss_tmo prior to fast_io_faillibmultipath/discovery.c libmultipath/sysfs.c libmultipath/sysfs.h+115 -170 replies
5/29libmultipath: return PATH_DOWN for quiesced pathslibmultipath/discovery.c+1 -00 replies
6/29libmultipath: Implement PATH_TIMEOUTlibmultipath/checkers.c libmultipath/checkers.h libmultipath/checkers/tur.c +2 more+14 -20 replies
7/29Deprecate pg_timeoutlibmultipath/config.c libmultipath/config.h libmultipath/configure.c +8 more+5 -1440 replies
8/29kpartx: create correct symlinks for PATH_FAILED eventskpartx/kpartx.rules+17 -10 replies
9/29multipath: Deprecate 'getuid' configuration variablelibmultipath/Makefile libmultipath/callout.c libmultipath/callout.h +9 more+354 -200 replies
10/29kpartx: support disk with non-512B sectorskpartx/dos.c kpartx/gpt.c kpartx/kpartx.c +1 more+31 -260 replies
11/29multipath: Add 'Datacore Virtual Disk' to internal hardware tablelibmultipath/hwtable.c+13 -00 replies
12/29Minor fixes for priority handlinglibmultipath/discovery.c libmultipath/propsel.c+2 -10 replies
13/29Check return value from pathinfo()libmultipath/configure.c libmultipath/discovery.c multipath/main.c+22 -90 replies
14/29Read directly from sysfs when checking the device sizelibmultipath/discovery.c libmultipath/sysfs.c+5 -80 replies
15/29multipath.conf.annotated: Document rr_min_io_rqmultipath.conf.annotated+16 -20 replies
16/29Correctly print out 'max' for max_fdslibmultipath/dict.c+7 -10 replies
17/29Correctly set max_fds in case of failurelibmultipath/dict.c+12 -30 replies
18/29Update multipath.conf.defaultsmultipath.conf.defaults+62 -480 replies
19/29Correctly set pgfailbacklibmultipath/config.c libmultipath/dict.c+6 -110 replies
20/29multipath.conf.5: clarify 'no_path_retry' default settingmultipath/multipath.conf.5+2 -10 replies
21/29multipath.conf.annotated: remove 'udev_dir'multipath.conf.annotated+0 -70 replies
22/29multipath: Implement 'property' blacklistlibmultipath/blacklist.c libmultipath/blacklist.h libmultipath/config.c +6 more+203 -320 replies
23/29Do not print error when rport is blockedlibmultipath/discovery.c libmultipath/sysfs.c+44 -280 replies
24/29multipath: reference the udev context when starting event queuelibmultipath/uevent.c libmultipath/uevent.h multipathd/main.c+17 -70 replies
25/29multipathd: valgrind fixeslibmultipath/discovery.c libmultipath/sysfs.c+21 -120 replies
26/29multipathd: increase stacksize for uevent listenermultipathd/main.c+4 -20 replies
27/29Specify checker_timeout in secondslibmultipath/checkers/emc_clariion.c libmultipath/checkers/hp_sw.c libmultipath/checkers/libsg.c +5 more+11 -110 replies
28/29multipath: fix setting of fast_io_fail_tmolibmultipath/discovery.c+1 -10 replies
29/29multipath: reset queue_if_no_path if flush failedlibmultipath/devmapper.c libmultipath/devmapper.h+18 -50 replies

Reviews trailers per patch

No Reviewed-by, Acked-by or Tested-by trailers for v1 yet.

Read the v1 thread

Cover letter [PATCH 00/29] SLES resync

Hi Christophe,

here as some patches which accumulated in my SLES repository. Most are plain bugfixes, but there are some nasty issues fixed with this:
- The conversion to libudev was a bit overzealous; originally we'd be skipping all devices which don't have a SCSI ID. With libudev we'd be including even those, making multipath claiming even USB flash disks :-(
So I've implemented a new 'property' blacklist which will allow us to blacklist devices based on the udev property.
- dev_loss_tmo setting continues to be tricky, but this time I think we've got it sorted
- When using libudev to read attribute variables we'd be getting an automated caching from libudev. Which is nice, unless the data changed in between. So I'd have to go back an roll our own accessors, skipping libudev here.
- Ripping out 'getuid_callout' rendered all old configuration files still using in unworkable. So I've re-introduced it by marked it 'obsolete'.

As usual, comments etc are welcome.

The patchset can also be pulled from
git://github.com/hreinecke/multipath-tools.git
branch sles-resync

Hannes Reinecke (27):
multipath: bind lifetime of udev context to main thread Document 'infinity' as possible value for dev_loss_tmo
alua: Do not add preferred path priority for active/optimized
multipath: Increase dev_loss_tmo prior to fast_io_fail
libmultipath: return PATH_DOWN for quiesced paths
libmultipath: Implement PATH_TIMEOUT
Deprecate pg_timeout
kpartx: create correct symlinks for PATH_FAILED events
multipath: Deprecate 'getuid' configuration variable
multipath: Add 'Datacore Virtual Disk' to internal hardware table Minor fixes for priority handling
Check return value from pathinfo()
Read directly from sysfs when checking the device size multipath.conf.annotated: Document rr_min_io_rq Correctly print out 'max' for max_fds
Correctly set max_fds in case of failure
Update multipath.conf.defaults
Correctly set pgfailback
multipath.conf.5: clarify 'no_path_retry' default setting multipath.conf.annotated: remove 'udev_dir'
multipath: Implement 'property' blacklist
Do not print error when rport is blocked
multipath: reference the udev context when starting event queue
multipathd: valgrind fixes
multipathd: increase stacksize for uevent listener Specify checker_timeout in seconds
multipath: reset queue_if_no_path if flush failed

Petr Uzel (2):
kpartx: support disk with non-512B sectors
multipath: fix setting of fast_io_fail_tmo

 kpartx/dos.c                         |   17 +--
 kpartx/gpt.c                         |   20 +---
 kpartx/kpartx.c                      |   12 ++
 kpartx/kpartx.h                      |    8 ++
 kpartx/kpartx.rules                  |   18 ++-
 libmpathpersist/mpath_persist.c      |    7 +-
 libmpathpersist/mpath_persist.h      |    2 +-
 libmpathpersist/mpath_pr_ioctl.c     |    5 +-
 libmultipath/Makefile                |    2 +-
 libmultipath/blacklist.c             |  105 +++++++++++++----
 libmultipath/blacklist.h             |   19 +--
 libmultipath/callout.c               |  216 ++++++++++++++++++++++++++++++++++
 libmultipath/callout.h               |    7 ++
 libmultipath/checkers.c              |    3 +-
 libmultipath/checkers.h              |    5 +
 libmultipath/checkers/emc_clariion.c |    2 +-
 libmultipath/checkers/hp_sw.c        |    4 +-
 libmultipath/checkers/libsg.c        |    2 +-
 libmultipath/checkers/rdac.c         |    4 +-
 libmultipath/checkers/tur.c          |    4 +-
 libmultipath/config.c                |   44 +++++--
 libmultipath/config.h                |   10 +-
 libmultipath/configure.c             |   25 ++--
 libmultipath/devmapper.c             |   31 ++---
 libmultipath/devmapper.h             |    3 +-
 libmultipath/dict.c                  |  195 ++++++++++++++++--------------
 libmultipath/discovery.c             |  170 +++++++++++++++++++-------
 libmultipath/discovery.h             |    2 +-
 libmultipath/hwtable.c               |   13 ++
 libmultipath/print.c                 |   35 ++++++
 libmultipath/prioritizers/alua.c     |    2 +-
 libmultipath/propsel.c               |   57 +++------
 libmultipath/propsel.h               |    1 -
 libmultipath/structs.h               |    2 +-
 libmultipath/structs_vec.c           |    2 +-
 libmultipath/sysfs.c                 |   86 ++++++++++++--
 libmultipath/sysfs.h                 |    2 +
 libmultipath/uevent.c                |   16 ++-
 libmultipath/uevent.h                |    4 +-
 mpathpersist/main.c                  |   11 +-
 multipath.conf.annotated             |   40 +++++--
 multipath.conf.defaults              |  112 ++++++++++--------
 multipath/main.c                     |   27 +++--
 multipath/multipath.conf.5           |   27 ++++-
 multipathd/main.c                    |   19 ++-
 45 files changed, 1007 insertions(+), 391 deletions(-)
 create mode 100644 libmultipath/callout.c
 create mode 100644 libmultipath/callout.h
Signature · 1 line
1.7.10.4