Skip to content

fec: Improve resources handling

Fabio Estevam netdev 1 version In review

Get series with b4
b4 am [email protected]

Versions newest first

  1. v1 Latest6 patches 2 repliesIn review

Patches in v1 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/6fec: Do not enable/disable optional clocks unconditionallydrivers/net/ethernet/freescale/fec_main.c+16 -80 replies
2/6fec: Fix the order for enabling/disabling the clocksdrivers/net/ethernet/freescale/fec_main.c+8 -80 replies
3/6fec: Enable/disable clk_ptp in suspend/resumedrivers/net/ethernet/freescale/fec_main.c+4 -00 replies
4/6fec: Check the return value from clk_prepare_enable()drivers/net/ethernet/freescale/fec_main.c+54 -120 replies
5/6fec: Remove unneeded check in platform_get_resource()drivers/net/ethernet/freescale/fec_main.c+1 -40 replies
6/6fec: Use devm_request_irq()drivers/net/ethernet/freescale/fec_main.c+3 -180 replies

Reviews trailers per patch

No Reviewed-by, Acked-by or Tested-by trailers for v1 yet.

Read the v1 thread

Cover letter [PATCH 0/6] fec: Improve resources handling

This series improves clock handling in the driver by not enabling/disabling the optional ptp and enet_out clocks unconditionally, check for the return value of clk_prepare_enable and also handle clk_ptp in suspend/resume.

Remove an unneeded check in platform_get_resource() and also use devm_request_irq() that can help to simplify the code.

Fabio Estevam (6):
fec: Do not enable/disable optional clocks unconditionally
fec: Fix the order for enabling/disabling the clocks
fec: Enable/disable clk_ptp in suspend/resume
fec: Check the return value from clk_prepare_enable()
fec: Remove unneeded check in platform_get_resource()
fec: Use devm_request_irq()

 drivers/net/ethernet/freescale/fec_main.c | 110 ++++++++++++++++++++----------
 1 file changed, 73 insertions(+), 37 deletions(-)
Signature · 1 line
1.8.1.2