Skip to content

'blockdev-add' QMP command

Kevin Wolf qemu-devel 1 version In review

Get series with b4
b4 am [email protected]

Versions newest first

  1. v1 Latest18 patches 40 repliesIn review

Patches in v1 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/18qapi-types.py: Split off generate_struct_fields()scripts/qapi-types.py+13 -61 reply
2/18qapi-types.py: Implement 'base' for unionsscripts/qapi-types.py+14 -210 replies
3/18qapi-visit.py: Split off generate_visit_struct_fields()scripts/qapi-visit.py+34 -281 reply
4/18qapi-visit.py: Implement 'base' for unionsscripts/qapi-visit.py+25 -51 reply
5/18docs: Document QAPI union typesdocs/qapi-code-gen.txt+53 -51 reply
6/18qapi: Add visitor for implicit structsinclude/qapi/visitor-impl.h include/qapi/visitor.h qapi/qapi-visit-core.c +1 more+37 -01 reply
7/18qapi: Flat unions with arbitrary discriminatordocs/qapi-code-gen.txt scripts/qapi-types.py scripts/qapi-visit.py+91 -235 replies
8/18qapi: Add consume argument to qmp_input_get_object()qapi/qmp-input-visitor.c+10 -91 reply
9/18qapi.py: Maintain a list of union typesscripts/qapi.py+13 -01 reply
10/18qapi: Anonymous unionsdocs/qapi-code-gen.txt include/qapi/qmp/qobject.h include/qapi/visitor-impl.h +7 more+160 -01 reply
11/18block: Allow "driver" option on the top levelblock.c blockdev.c+17 -101 reply
12/18QemuOpts: Add qemu_opt_unset()include/qemu/option.h util/qemu-option.c+15 -01 reply
13/18blockdev: Rename I/O throttling options for QMPblockdev.c+39 -137 replies
14/18qcow2: Use dashes instead of underscores in optionsblock/qcow2.h+4 -41 reply
15/18blockdev: Rename 'readonly' option to 'read-only'blockdev.c+6 -41 reply
16/18blockdev: Split up 'cache' optionblockdev.c+47 -101 reply
17/18Implement qdict_flatten()include/qapi/qmp/qdict.h qobject/qdict.c+51 -02 replies
18/18blockdev: 'blockdev-add' QMP commandblockdev.c qapi-schema.json qmp-commands.hx+364 -05 replies

Reviews trailers per patch

17 of 18 patches have a Reviewed-by or Acked-by.

PatchEric Blake
1/18R-b
2/18R-b
3/18R-b
4/18R-b
5/18R-b
6/18R-b
7/18R-b R-b R-b
8/18R-b
9/18R-b
10/18R-b
11/18R-b
12/18R-b
13/18R-b
14/18R-b
15/18R-b
16/18R-b
17/18R-b
18/18

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes.

Read the v1 thread

Cover letter [Qemu-devel] [PATCH 00/18] 'blockdev-add' QMP command

Kevin Wolf (18):
qapi-types.py: Split off generate_struct_fields() qapi-types.py: Implement 'base' for unions qapi-visit.py: Split off generate_visit_struct_fields() qapi-visit.py: Implement 'base' for unions
docs: Document QAPI union types
qapi: Add visitor for implicit structs
qapi: Flat unions with arbitrary discriminator
qapi: Add consume argument to qmp_input_get_object() qapi.py: Maintain a list of union types
qapi: Anonymous unions
block: Allow "driver" option on the top level
QemuOpts: Add qemu_opt_unset()
blockdev: Rename I/O throttling options for QMP
qcow2: Use dashes instead of underscores in options
blockdev: Rename 'readonly' option to 'read-only'
blockdev: Split up 'cache' option
Implement qdict_flatten()
blockdev: 'blockdev-add' QMP command

 block.c                     |   7 ++
 block/qcow2.h               |   8 +-
 blockdev.c                  | 184 ++++++++++++++++++++++------
 docs/qapi-code-gen.txt      | 105 +++++++++++++++-
 include/qapi/qmp/qdict.h    |   1 +
 include/qapi/qmp/qobject.h  |   1 +
 include/qapi/visitor-impl.h |   6 +
 include/qapi/visitor.h      |   6 +
 include/qemu/option.h       |   1 +
 qapi-schema.json            | 293 ++++++++++++++++++++++++++++++++++++++++++++
 qapi/qapi-visit-core.c      |  25 ++++
 qapi/qmp-input-visitor.c    |  47 +++++--
 qmp-commands.hx             |  26 ++++
 qobject/qdict.c             |  50 ++++++++
 qobject/qjson.c             |   2 +
 scripts/qapi-types.py       |  83 +++++++++++--
 scripts/qapi-visit.py       | 179 ++++++++++++++++++++++-----
 scripts/qapi.py             |  28 +++++
 util/qemu-option.c          |  14 +++
 19 files changed, 970 insertions(+), 96 deletions(-)
Signature · 1 line
1.8.1.4