tcg-aarch64 improvements
Get series with b4
b4 am [email protected]Versions newest first · linked by author and title
- v4 Latest33 patches 32 repliesIn review
- v3 posting 2/229 patches 28 repliesSuperseded
- v3 posting 1/20 of 29 patches 0 repliesSuperseded
Earlier versions · 1
| Version | Posted | Patches | Replies | Status |
|---|---|---|---|---|
| v1 RFC | 14 patches | 0 replies | Superseded |
Changes in v4 from the cover letter
* Using TCGType instead of bool for the ext variables.
* Marginal tidying of the tcg_fmt_* functions to match fields names with the architecture document now that it's released. In particular, the ext variables incoming to them have been renamed "sf". I have not propagated that change all the way back up the call chain.
* Split up the movi improvements into 3 separate patches. I also fixed the bug therein that affected i386-softmmu booting. I've also significantly improved the documentation in that function.
* I came up with a significantly faster way to actually perform the MOVN check, although I didn't confuse the issue by actually implementing it, since it requires using the neon unit, and probably real hardware to see what kind of inter-unit slow down there is. It's left as a comment. I actually suspect that the parallelism of the A57 is high enough to support performing 3 tests at once, deciding which of the 3 alternatives at once at the end.
* Split up the movcond addition and setcond cleanup. I did not find a problem in either patch, as suggested during the previous review.
* Rebase vs head, 2d1fe18.
Patches in v4 No applies recorded yet
| # | Subject and files | Size | Replies | Applied |
|---|---|---|---|---|
| 1/33 | tcg-aarch64: Change all ext variables to TCGTypetcg/ | +37 | 0 replies | |
| 2/33 | tcg-aarch64: Set ext based on TCG_OPF_64BITtcg/ | +7 | 0 replies | |
| 3/33 | tcg-aarch64: Don't handle mov/movi in tcg_out_optcg/ | +7 | 3 replies | |
| 4/33 | tcg-aarch64: Hoist common argument loads in tcg_out_optcg/ | +50 | 7 replies | |
| 5/33 | tcg-aarch64: Change enum aarch64_arith_opc to AArch64Insntcg/ | +23 | 0 replies | |
| 6/33 | tcg-aarch64: Merge enum aarch64_srr_opc with AArch64Insntcg/ | +24 | 3 replies | |
| 7/33 | tcg-aarch64: Remove the shift_imm parameter from tcg_out_cmptcg/ | +5 | 1 reply | |
| 8/33 | tcg-aarch64: Introduce tcg_fmt_Rdnm and tcg_fmt_Rdnm_lsltcg/ | +38 | 8 replies | |
| 9/33 | tcg-aarch64: Introduce tcg_fmt_Rdn_aimmtcg/ | +31 | 1 reply | |
| 10/33 | tcg-aarch64: Implement mov with tcg_fmt_* functionstcg/ | +10 | 1 reply | |
| 11/33 | tcg-aarch64: Handle constant operands to add, sub, and comparetcg/ | +80 | 3 replies | |
| 12/33 | tcg-aarch64: Handle constant operands to and, or, xortcg/ | +106 | 0 replies | |
| 13/33 | tcg-aarch64: Support andc, orc, eqv, nottcg/ tcg/ | +65 | 0 replies | |
| 14/33 | tcg-aarch64: Handle zero as first argument to subtcg/ | +24 | 0 replies | |
| 15/33 | tcg-aarch64: Support movcondtcg/ tcg/ | +25 | 0 replies | |
| 16/33 | tcg-aarch64: Use tcg_fmt_Rdnm_cond for setcondtcg/ | +3 | 0 replies | |
| 17/33 | tcg-aarch64: Support deposittcg/ tcg/ | +38 | 0 replies | |
| 18/33 | tcg-aarch64: Support add2, sub2tcg/ tcg/ | +82 | 0 replies | |
| 19/33 | tcg-aarch64: Support muluh, mulshtcg/ tcg/ | +14 | 0 replies | |
| 20/33 | tcg-aarch64: Support div, remtcg/ tcg/ | +46 | 0 replies | |
| 21/33 | tcg-aarch64: Introduce tcg_fmt_Rd_uimmtcg/ | +28 | 0 replies | |
| 22/33 | tcg-aarch64: Use MOVN in tcg_out_movitcg/ | +75 | 4 replies | |
| 23/33 | tcg-aarch64: Use ORRI in tcg_out_movitcg/ | +9 | 0 replies | |
| 24/33 | tcg-aarch64: Special case small constants in tcg_out_movitcg/ | +11 | 0 replies | |
| 25/33 | tcg-aarch64: Use adrp in tcg_out_movitcg/ | +22 | 0 replies | |
| 26/33 | tcg-aarch64: Avoid add with zero in tlb loadtcg/ | +18 | 0 replies | |
| 27/33 | tcg-aarch64: Pass return address to load/store helpers directly.include/ tcg/ | +26 | 0 replies | |
| 28/33 | tcg-aarch64: Use tcg_out_call for qemu_ld/sttcg/ | +2 | 0 replies | |
| 29/33 | tcg-aarch64: Use symbolic names for branchestcg/ | +24 | 0 replies | |
| 30/33 | tcg-aarch64: Implement tcg_register_jittcg/ | +70 | 0 replies | |
| 31/33 | tcg-aarch64: Reuse FP and LR in translated codetcg/ tcg/ | +32 | 0 replies | |
| 32/33 | tcg-aarch64: Introduce tcg_out_ldst_pairtcg/ | +27 | 0 replies | |
| 33/33 | tcg-aarch64: Remove redundant CPU_TLB_ENTRY_BITS checktcg/ | +0 | 1 reply |
Reviews trailers per patch
2 of 33 patches have a Reviewed-by or Acked-by.
| Patch | Claudio Fontana |
|---|---|
| 1/33 | |
| 2/33 | |
| 3/33 | |
| 4/33 | |
| 5/33 | |
| 6/33 | |
| 7/33 | R-b |
| 8/33 | |
| 9/33 | |
| 10/33 | |
| 11/33 | |
| 12/33 | |
| 13/33 | |
| 14/33 | |
| 15/33 | |
| 16/33 | |
| 17/33 | |
| 18/33 | |
| 19/33 | |
| 20/33 | |
| 21/33 | |
| 22/33 | |
| 23/33 | |
| 24/33 | |
| 25/33 | |
| 26/33 | |
| 27/33 | |
| 28/33 | |
| 29/33 | |
| 30/33 | |
| 31/33 | |
| 32/33 | |
| 33/33 | R-b |
Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes.
Cover letter [Qemu-devel] [PATCH v4 00/33] tcg-aarch64 improvements
Changes since v3:
* Using TCGType instead of bool for the ext variables.
* Marginal tidying of the tcg_fmt_* functions to match fields names with the architecture document now that it's released. In particular, the ext variables incoming to them have been renamed "sf". I have not propagated that change all the way back up the call chain.
* Split up the movi improvements into 3 separate patches. I also fixed the bug therein that affected i386-softmmu booting. I've also significantly improved the documentation in that function.
* I came up with a significantly faster way to actually perform the MOVN check, although I didn't confuse the issue by actually implementing it, since it requires using the neon unit, and probably real hardware to see what kind of inter-unit slow down there is. It's left as a comment. I actually suspect that the parallelism of the A57 is high enough to support performing 3 tests at once, deciding which of the 3 alternatives at once at the end.
* Split up the movcond addition and setcond cleanup. I did not find a problem in either patch, as suggested during the previous review.
* Rebase vs head, 2d1fe18.
Tested bios boots of i386-softmmu, alpha-softmmu, sparc-softmmu. Tested a full run of Paulo's sieve{32,64}.flat. Takes around an hour to run under the Foundation model. Ouch.
r~
Richard Henderson (33):
tcg-aarch64: Change all ext variables to TCGType
tcg-aarch64: Set ext based on TCG_OPF_64BIT
tcg-aarch64: Don't handle mov/movi in tcg_out_op
tcg-aarch64: Hoist common argument loads in tcg_out_op
tcg-aarch64: Change enum aarch64_arith_opc to AArch64Insn
tcg-aarch64: Merge enum aarch64_srr_opc with AArch64Insn
tcg-aarch64: Remove the shift_imm parameter from tcg_out_cmp
tcg-aarch64: Introduce tcg_fmt_Rdnm and tcg_fmt_Rdnm_lsl
tcg-aarch64: Introduce tcg_fmt_Rdn_aimm
tcg-aarch64: Implement mov with tcg_fmt_* functions
tcg-aarch64: Handle constant operands to add, sub, and compare
tcg-aarch64: Handle constant operands to and, or, xor
tcg-aarch64: Support andc, orc, eqv, not
tcg-aarch64: Handle zero as first argument to sub
tcg-aarch64: Support movcond
tcg-aarch64: Use tcg_fmt_Rdnm_cond for setcond
tcg-aarch64: Support deposit
tcg-aarch64: Support add2, sub2
tcg-aarch64: Support muluh, mulsh
tcg-aarch64: Support div, rem
tcg-aarch64: Introduce tcg_fmt_Rd_uimm
tcg-aarch64: Use MOVN in tcg_out_movi
tcg-aarch64: Use ORRI in tcg_out_movi
tcg-aarch64: Special case small constants in tcg_out_movi
tcg-aarch64: Use adrp in tcg_out_movi
tcg-aarch64: Avoid add with zero in tlb load
tcg-aarch64: Pass return address to load/store helpers directly.
tcg-aarch64: Use tcg_out_call for qemu_ld/st
tcg-aarch64: Use symbolic names for branches
tcg-aarch64: Implement tcg_register_jit
tcg-aarch64: Reuse FP and LR in translated code
tcg-aarch64: Introduce tcg_out_ldst_pair
tcg-aarch64: Remove redundant CPU_TLB_ENTRY_BITS check
include/exec/exec-all.h | 11 - tcg/aarch64/tcg-target.c | 1352 ++++++++++++++++++++++++++++++---------------- tcg/aarch64/tcg-target.h | 76 +-- 3 files changed, 940 insertions(+), 499 deletions(-)
Signature · 1 line
1.8.3.1