Skip to content

6lowpan: address uncompression fixes

Alexander Aring netdev 3 versions – In review

Get series with b4
b4 am [email protected]

Versions newest first · linked by author and title

  1. v3 Latest6 patches 2 repliesIn review
  2. v26 patches 9 repliesSuperseded
  3. v14 of 6 patches 0 repliesSuperseded

Changes in v3 from the cover letter

- Add tags for net-next
- Change commit msg in Patch 1/6 that this patch depends for the following patches

Patches in v3 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/66lowpan: init ipv6hdr buffer to zeronet/ieee802154/6lowpan.c+1 -110 replies
2/66lowpan: Fix fragmentation with link-local compressed addressesnet/ieee802154/6lowpan.c+6 -00 replies
3/66lowpan: introduce lowpan_fetch_skb functionnet/ieee802154/6lowpan.h+12 -00 replies
4/66lowpan: add function to uncompress multicast addrnet/ieee802154/6lowpan.c+59 -190 replies
5/66lowpan: lowpan_uncompress_addr with address_modenet/ieee802154/6lowpan.c net/ieee802154/6lowpan.h+82 -710 replies
6/66lowpan: handle context based source addressnet/ieee802154/6lowpan.c+46 -30 replies

Reviews trailers per patch

All 6 patches have a Reviewed-by or Acked-by.

PatchWerner Almesberger
1/6R-b
2/6R-b
3/6R-b
4/6R-b
5/6R-b
6/6R-b

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes.

Read the v3 thread

Cover letter [PATCHv3 net-next 0/6] 6lowpan: address uncompression fixes

The current implementation to uncompress addresses in a 6lowpan header is completely broken.

This patch series fixes the parsing of addresses in a 6lowpan header. It contains a major rewrite of the uncompress address function to parse the address in a correct way.

Tested with the ravenusbstick(contiki 6LoWPAN stack) and beaglebone (linux 6LoWPAN Stack) on the other side. The linux side contains all possible addresses for the uncompression cases. Then I type a ping6 for each case and lookup in wireshark and dmesg the correct reconstruction.

Please apply this patch series on net-next in order 1/7 to 7/7.

Changes since v3:
- Fix byte ordering problem in uncompression of short-address. Thanks for this hint.
- drop pr_debug before lowpan_raw_dump_inline

Changes since v2:
- Add tags for net-next
- Change commit msg in Patch 1/6 that this patch depends for the following patches

Alexander Aring (5):
6lowpan: init ipv6hdr buffer to zero 6lowpan: introduce lowpan_fetch_skb function 6lowpan: add function to uncompress multicast addr 6lowpan: lowpan_uncompress_addr with address_mode 6lowpan: handle context based source address

David Hauweele (1):
6lowpan: Fix fragmentation with link-local compressed addresses

 net/ieee802154/6lowpan.c | 286 +++++++++++++++++++++++++++++++----------------
 net/ieee802154/6lowpan.h |  20 +++-
 2 files changed, 204 insertions(+), 102 deletions(-)
Signature · 9 lines
1.8.3.3


------------------------------------------------------------------------------
Get 100% visibility into Java/.NET code with AppDynamics Lite!
It's a free troubleshooting tool designed for production.
Get down to code-level detail for bottlenecks, with <2% overhead. 
Download for free and get started troubleshooting in minutes. 
http://pubads.g.doubleclick.net/gampad/clk?id=48897031&iu=/4140/ostg.clktrk