Skip to content

hfp_hf_bluez5: Add support for Transparent SCO

Vinicius Costa Gomes ofono 1 version In review

Get series with b4
b4 am [email protected]

Versions newest first

  1. v1 Latest6 patches 13 repliesIn review

Patches in v1 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/6bluetooth: Add define for SCO voice settingssrc/bluetooth.h+9 -01 reply
2/6handsfree-audio: Add setting SCO air modesrc/handsfree-audio.c+18 -02 replies
3/6handsfree-audio: Add support for detecting Transparent SCO supportinclude/handsfree-audio.h plugins/hfp_hf_bluez5.c src/handsfree-audio.c+19 -82 replies
4/6handsfree-audio: Set the voice setting for outgoing connectionssrc/handsfree-audio.c+8 -01 reply
5/6hfp_hf_bluez5: Handle org.bluez.Profile1.Cancel()plugins/hfp_hf_bluez5.c+1 -30 replies
6/6hfp_hf_bluez5: Handle org.bluez.Profile1.Release()plugins/hfp_hf_bluez5.c+1 -37 replies

Reviews trailers per patch

No Reviewed-by, Acked-by or Tested-by trailers for v1 yet.

Read the v1 thread

Cover letter [PATCH 0/6] hfp_hf_bluez5: Add support for Transparent SCO

Hi,

Sorry for the delay.

This series adds support for using transparent SCO, necessary for wideband speech, the main feature is that it should do the right thing even if the kernel doesn't have code for this.

The last two patches add some missing method implementations to the Profile1 interface. One is more or less clear that there's nothing to do, the other is less clear.

For .Cancel(): we only receive the .Cancel() message if the we will not receive the NewConnection() call, so there's nothing to cancel for the ofono side.

For .Release(): right now, this is doing nothing. Perhaps it would be worth changing it to stop listening for SCO connections. Which would mean to only start listening when the profile is registered. Does this make sense?

Cheers,
Vinicius

Vinicius Costa Gomes (6):
bluetooth: Add define for SCO voice settings
handsfree-audio: Add setting SCO air mode
handsfree-audio: Add support for detecting Transparent SCO support
handsfree-audio: Set the voice setting for outgoing connections
hfp_hf_bluez5: Handle org.bluez.Profile1.Cancel()
hfp_hf_bluez5: Handle org.bluez.Profile1.Release()

 include/handsfree-audio.h |  2 +-
 plugins/hfp_hf_bluez5.c   | 10 +++-------
 src/bluetooth.h           |  9 +++++++++
 src/handsfree-audio.c     | 49 +++++++++++++++++++++++++++++++++++++++++------
 4 files changed, 56 insertions(+), 14 deletions(-)
Signature · 1 line
1.8.3.4