Skip to content

acpi: Fix and cleanup in acpi.

Tang Chen linux-acpi lkml 2 versions – In review

Get series with b4
b4 am [email protected]

Versions newest first · linked by author and title

  1. v2 Latest4 patches 5 repliesIn review
  2. v16 patches 8 repliesSuperseded

Changes in v2 from the cover letter

1. Use pr_fmt() to simply the SRAT message.
Suggested by Joe Perches <[email protected]>
2. Improve the log in patch 4, and change the return value of the stub of acpi_table_parse() in linux/acpi.h
Suggested by Toshi Kani <[email protected]>
3. Merge the two pr_{info|err} patches into one.
4. Remove on of the patch that has been merged by Rafael.

Patches in v2 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/4acpi, numa, mem_hotplug: Kill save_add_info().arch/x86/mm/srat.c+0 -80 replies
2/4acpi cleanup: Use pr_{info|err}() instead of printk() in arch/x86/mm/srat.carch/x86/mm/srat.c+17 -151 reply
3/4acpi: Check if @id is NULL in acpi_table_parse()drivers/acpi/tables.c+1 -10 replies
4/4acpi: Return -ENOENT in acpi_table_parse() and fix wrong comment.drivers/acpi/tables.c include/linux/acpi.h+5 -41 reply

Reviews trailers per patch

All 4 patches have a Reviewed-by or Acked-by.

PatchToshi Kani
1/4A-b
2/4A-b
3/4A-b
4/4A-b

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes.

Read the v2 thread

Cover letter [PATCH v2 0/4] acpi: Fix and cleanup in acpi.

This patch-set fix the following problems:

1. Kill useless function save_add_info() which will block us from using numa when MEMORY_HOTPLUG is not configured.
2. acpi_table_parse() didn't check if @id is NULL.
3. Fix incorrect comment in acpi_table_parse(), and return -ENOENT if a table is not found.

And also did some cleanup.

change log v1 -> v2:
1. Use pr_fmt() to simply the SRAT message.
Suggested by Joe Perches <[email protected]>
2. Improve the log in patch 4, and change the return value of the stub of acpi_table_parse() in linux/acpi.h
Suggested by Toshi Kani <[email protected]>
3. Merge the two pr_{info|err} patches into one.
4. Remove on of the patch that has been merged by Rafael.

Tang Chen (4):
acpi, numa, mem_hotplug: Kill save_add_info(). acpi cleanup: Use pr_{info|err}() instead of printk() in

    arch/x86/mm/srat.c

acpi: Check if @id is NULL in acpi_table_parse()
acpi: Return -ENOENT in acpi_table_parse() and fix wrong comment.

 arch/x86/mm/srat.c    |   40 +++++++++++++++++-----------------------
 drivers/acpi/tables.c |    9 +++++----
 include/linux/acpi.h  |    2 +-
 3 files changed, 23 insertions(+), 28 deletions(-)