Skip to content

cpsw: support for control module register

Daniel Mack linux-arm-kernel linux-devicetree linux-omap netdev 6 versions – In review

Get series with b4
b4 am [email protected]

Versions newest first · linked by author and title

  1. v6 Latest5 patches 4 repliesIn review
  2. v55 patches 4 repliesSuperseded
  3. v45 patches 27 repliesSuperseded
Earlier versions · 3
VersionPostedPatchesRepliesStatus
v35 patches0 repliesSuperseded
v25 patches7 repliesSuperseded
v14 patches7 repliesSuperseded

Changes in v6 from the cover letter

* re-add code to fail if 3rd memory region is given but invalid
* added Mugunthan's ack on all patches except the one that adds ti,am3352-cpsw
* remove parens around integer constants

Patches in v6 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/5net: ethernet: cpsw: switch to devres allocationsdrivers/net/ethernet/ti/cpsw.c+43 -1100 replies
2/5net: ethernet: cpsw: add optional third memory region for CONTROL moduleDocumentation/devicetree/bindings/net/cpsw.txt drivers/net/ethernet/ti/cpsw.c+15 -12 replies
3/5net: ethernet: cpsw: introduce ti,am3352-cpsw compatible stringDocumentation/devicetree/bindings/net/cpsw.txt drivers/net/ethernet/ti/cpsw.c drivers/net/ethernet/ti/cpsw.h+28 -80 replies
4/5net: ethernet: cpsw: add support for hardware interface mode configDocumentation/devicetree/bindings/net/cpsw.txt drivers/net/ethernet/ti/cpsw.c drivers/net/ethernet/ti/cpsw.h+68 -00 replies
5/5ARM: dts: am33xx: adopt to cpsw changesarch/arm/boot/dts/am33xx.dtsi+3 -20 replies

Reviews trailers per patch

4 of 5 patches have a Reviewed-by or Acked-by.

PatchMugunthan V N
1/5A-b
2/5A-b
3/5
4/5A-b
5/5A-b

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes.

Read the v6 thread

Cover letter [PATCH v6 0/5] cpsw: support for control module register

Hi,

this is the 6th version of my patch set, the version history is below.

Note that for personal reasons, I won't be able to work on that patch set for two weeks, starting from a few hours from now. If there are any more objections or comments, I'll catch up after that period. Or if anyone wants to make minor changes to my patches and resubmit them, I'd also be fine with that :)

The compatibility discussion is still ongoing, but I'd rather submit what I got until now, and I'm also still convinced that having ti,am3352-cpsw is the best we can do.

Thanks,
Daniel

v5 -> v6:
* re-add code to fail if 3rd memory region is given but invalid
* added Mugunthan's ack on all patches except the one that adds ti,am3352-cpsw
* remove parens around integer constants

v4 -> v5:
* fix return value assignment in devm_ioremap_resource() error paths (reported by Sergei Shtylyov)
* add more RGMII modes (reported by Mugunthan V N)
* check for IS_ERR(priv->gmii_sel_reg) in cpsw_set_phy_interface_mode() (reported by Mugunthan V N)
* move SoC specific definitions to cpsw.h
* further simplify the probe logic, as devm_ioremap_resource() will check for NULL resources (Sergei Shtylyov)

v3 -> v4:
* use IS_ERR() to check for failed devm_ioremap_resource() calls (reported by Sergei Shtylyov)

v2 -> v3:
* swap "ti,am3352-cpsw" and "ti,cpsw" to work around a matching bug (reported by Sekhar)

v1 -> v2:
* combine devm_request_mem_region() and devm_ioremap() and use devm_ioremap_resource() (reported by Sergei Shtylyov)
* fix multi-line comment style (reported by Sergei Shtylyov)
* fix ti,rmii-clock-ext property name (reported by Sekhar)
* rebased to net-next (reported by Mugunthan V N, David Miller)
* add a new compatible type, and handle AM33xx specific registers that way (reported by Sekhar)
* move gmii_sel_reg modifications to the open routine (reported by Mugunthan V N)

Daniel Mack (5):
net: ethernet: cpsw: switch to devres allocations
net: ethernet: cpsw: add optional third memory region for CONTROL
module
net: ethernet: cpsw: introduce ti,am3352-cpsw compatible string
net: ethernet: cpsw: add support for hardware interface mode config
ARM: dts: am33xx: adopt to cpsw changes

 Documentation/devicetree/bindings/net/cpsw.txt |  10 +-
 arch/arm/boot/dts/am33xx.dtsi                  |   5 +-
 drivers/net/ethernet/ti/cpsw.c                 | 252 +++++++++++++------------
 drivers/net/ethernet/ti/cpsw.h                 |   9 +
 4 files changed, 156 insertions(+), 120 deletions(-)
Signature · 1 line
1.8.3.1