Skip to content

powerpc: use jump label for cpu/mmu_has_feature

Kevin Hao linuxppc-dev 2 versions – In review

Get series with b4
b4 am [email protected]

Versions newest first · linked by author and title

  1. v2 Latest3 patches 2 repliesIn review
  2. v15 patches 2 repliesSuperseded

Changes in v2 from the cover letter

- Rebase on git://git.kernel.org/pub/scm/linux/kernel/git/next/linux-next.git master since these patches have a dependence on patch 851cf6e7 (jump_label:
Split jumplabel ratelimit)

- Drop the first two patches in v1 since they are not needed due to

Patches in v2 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/3powerpc: move the cpu_has_feature to a separate filearch/powerpc/include/asm/cacheflush.h arch/powerpc/include/asm/cpufeatures.h arch/powerpc/include/asm/cputable.h +14 more+29 -80 replies
2/3powerpc: use the jump label for cpu_has_featurearch/powerpc/include/asm/cpufeatures.h arch/powerpc/kernel/cputable.c+50 -02 replies
3/3powerpc: use jump label for mmu_has_featurearch/powerpc/include/asm/mmu.h arch/powerpc/kernel/cputable.c+39 -00 replies

Reviews trailers per patch

No Reviewed-by, Acked-by or Tested-by trailers for v2 yet.

Read the v2 thread

Cover letter [PATCH v2 0/3] powerpc: use jump label for cpu/mmu_has_feature

v2:
- Rebase on git://git.kernel.org/pub/scm/linux/kernel/git/next/linux-next.git master since these patches have a dependence on patch 851cf6e7 (jump_label:
Split jumplabel ratelimit)

- Drop the first two patches in v1 since they are not needed due to

    the patch 851cf6e7.

v1:
Inspired by Benjamin Herrenschmidt, this patch series try to reduce the cpu/mmu feature checking overhead by using jump label. The following is the difference of the run path of cpu_has_feature between before and after applying these patches:

before after

  addis   r10,r2,1                   b xxx
  addi    r9,r10,-2280               b xxx (This will also be omitted if the

ld r9,0(r9) feature is not set)
ld r9,16(r9)
rldicl. r8,r9,55,63
beq c000000000037c94

This patch series passed the build test for almost all the defconfig of ppc. There does have some broken for some configs. But they are not related to this change. This also passed allyesconfig for x86. Boot test on p2020rdb and p5020ds boards.

Kevin Hao (3):
powerpc: move the cpu_has_feature to a separate file
powerpc: use the jump label for cpu_has_feature
powerpc: use jump label for mmu_has_feature

 arch/powerpc/include/asm/cacheflush.h   |  1 +
 arch/powerpc/include/asm/cpufeatures.h  | 41 +++++++++++++++++++++++++++++++
 arch/powerpc/include/asm/cputable.h     |  8 ------
 arch/powerpc/include/asm/cputime.h      |  1 +
 arch/powerpc/include/asm/dbell.h        |  1 +
 arch/powerpc/include/asm/dcr-native.h   |  1 +
 arch/powerpc/include/asm/mman.h         |  1 +
 arch/powerpc/include/asm/mmu.h          | 19 +++++++++++++++
 arch/powerpc/include/asm/time.h         |  1 +
 arch/powerpc/kernel/align.c             |  1 +
 arch/powerpc/kernel/cputable.c          | 43 +++++++++++++++++++++++++++++++++
 arch/powerpc/kernel/irq.c               |  1 +
 arch/powerpc/kernel/process.c           |  1 +
 arch/powerpc/kernel/setup-common.c      |  1 +
 arch/powerpc/kernel/setup_32.c          |  1 +
 arch/powerpc/kernel/smp.c               |  1 +
 arch/powerpc/oprofile/op_model_rs64.c   |  1 +
 arch/powerpc/platforms/cell/pervasive.c |  1 +
 arch/powerpc/xmon/ppc-dis.c             |  1 +
 19 files changed, 118 insertions(+), 8 deletions(-)
 create mode 100644 arch/powerpc/include/asm/cpufeatures.h
Signature · 1 line
1.8.3.1