Skip to content

Input/HID: Guitar/Drums support

David Herrmann linux-input 1 version Applied

Status from this message: Applied, thanks!

Get series with b4
b4 am [email protected]

Versions newest first

  1. v1 Latest3 patches 4 repliesApplied

Patches in v1 Applied

#Subject and filesSizeRepliesApplied
1/3Input: introduce BTN/ABS bits for drums and guitarsinclude/linux/mod_devicetable.h include/uapi/linux/input.h+24 -33 replies
2/3HID: wiimote: add support for Guitar-Hero drumsdrivers/hid/hid-wiimote-core.c drivers/hid/hid-wiimote-modules.c drivers/hid/hid-wiimote.h+227 -00 replies
3/3HID: wiimote: add support for Guitar-Hero guitarsdrivers/hid/hid-wiimote-core.c drivers/hid/hid-wiimote-modules.c drivers/hid/hid-wiimote.h+182 -00 replies

Reviews trailers per patch

1 of 3 patches has a Reviewed-by or Acked-by.

PatchNicolas Adenis-LamarreDmitry Torokhov
1/3A-b
2/3Initial-work-by
3/3

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes.

Read the v1 thread

Cover letter [PATCH 0/3] Input/HID: Guitar/Drums support

Hi

This series adds wiimote extension support for guitars and drums. The patches are fairly simple and work the same as the other 5 wiimote extensions. But as we currently don't have IDs to report drums or guitar events to user-space, I had to add them.

Patch #1 adds basic IDs to <linux/input.h>. I tried to find as many devices as I could and looked what IDs would be required. Turned out, the device I was implementing already supported almost all (except 2 instead of 4 cymbals and 3 instead of 4 toms).

Patch #2 and #3 add the wiimote extensions.

This has been mostly worked out and tested by Nicolas (thanks!) and we started this work almost 3 month ago. Due to holidays it took a bit longer to get pressure reports working. But now everything should be fine.

The xwiimote user-space tools already support this and provide testing utilities if someone is interested: http://github.com/dvdhrm/xwiimote

Jiri, Dmitry, can we try merging this for 3.13? I know it's late, but it did see a lot of testing from Nicolas.

Regards
David

Btw., if someone has similar PS3 or WorldTour devices, I'd be glad to add support for them!

David Herrmann (2):
Input: introduce BTN/ABS bits for drums and guitars
HID: wiimote: add support for Guitar-Hero drums

Nicolas Adenis-Lamarre (1):
HID: wiimote: add support for Guitar-Hero guitars

 drivers/hid/hid-wiimote-core.c    |  14 ++
 drivers/hid/hid-wiimote-modules.c | 392 ++++++++++++++++++++++++++++++++++++++
 drivers/hid/hid-wiimote.h         |   3 +
 include/linux/mod_devicetable.h   |   2 +-
 include/uapi/linux/input.h        |  25 ++-
 5 files changed, 433 insertions(+), 3 deletions(-)
Signature · 1 line
1.8.4