Skip to content

Make mixer emulation configurable at runtime

Bandan Das qemu-devel 3 versions – In review

Get series with b4
b4 am [email protected]

Versions newest first · linked by author and title

  1. v3 Latest3 patches 1 replyIn review
  2. v23 patches 4 repliesSuperseded
  3. v12 patches 9 repliesSuperseded

Changes in v3 from the cover letter

* Remove malc from cc, delivery failure to Vassili Karpov (malc)" <[email protected]> Anyone know the correct email address ?
* Remove unneeded dummies - Patch 2/3
* Minor fprintf reformatting - Patch 2/3
* Reduce commit message verbosity - Patch 3/3

Patches in v3 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/3hda-codec: refactor common definitions into a header filehw/audio/hda-codec-common.h hw/audio/hda-codec.c+450 -4230 replies
2/3hda-codec: make mixemu selectable at runtimehw/audio/hda-codec-common.h hw/audio/hda-codec.c+122 -590 replies
3/3audio: remove CONFIG_MIXEMU configure optionaudio/mixeng.c configure hw/audio/hda-codec.c+0 -440 replies

Reviews trailers per patch

None of the 3 patches has a Reviewed-by or Acked-by of their own; the series has one for all of them.

PatchGerd Hoffmann
SeriesR-b
1/3
2/3
3/3

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes.

Read the v3 thread

Cover letter [Qemu-devel] [PATCH v3 0/3] Make mixer emulation configurable at runtime

Currently, hda-codec mixer emulation can only be enabled by using the "--enable-mixemu" option to configure at compile time with the default value being off. These patches enable making mixer emulation selectable at runtime which is more convenient. Consequently, the last patch in this series removes the mixemu configuration option.

Example Usage:
1. -device hda-duplex,mixer=off
2. -device hda-duplex,mixer=on [Default]

v3:
* Remove malc from cc, delivery failure to Vassili Karpov (malc)" <[email protected]> Anyone know the correct email address ?
* Remove unneeded dummies - Patch 2/3
* Minor fprintf reformatting - Patch 2/3
* Reduce commit message verbosity - Patch 3/3

v2:
* Add copyright information - Patch 1/3
* Edit description for readability - Patch 1/3
* Catch error paths in instance init functions - Patch 2/3
* Define "mixer" as a bool - Patch 2/3
* Preserve CONFIG_MIXEMU state - Patch 2/3
* Remove the --enable-mixemu configuration option - Patch 3/3

Bandan Das (3):
hda-codec: refactor common definitions into a header file
hda-codec: make mixemu selectable at runtime
audio: remove CONFIG_MIXEMU configure option

 audio/mixeng.c              |   6 -
 configure                   |   8 -
 hw/audio/hda-codec-common.h | 456 ++++++++++++++++++++++++++++++++++++++++++++
 hw/audio/hda-codec.c        | 454 +++----------------------------------------
 4 files changed, 485 insertions(+), 439 deletions(-)
 create mode 100644 hw/audio/hda-codec-common.h
Signature · 1 line
1.8.1.4