xfs: prevent transient corrupt states during log recovery
Get series with b4
b4 am [email protected]Versions newest first
- v1 Latest2 patches 9 repliesIn review
Patches in v1 No applies recorded yet
| # | Subject and files | Size | Replies | Applied |
|---|---|---|---|---|
| 1/2 | xfs: btree block LSN escaping to disk uninitialisedfs/ | +2 | 3 replies | |
| 2/2 | xfs: check LSN ordering for v5 superblocks during recoveryfs/ | +156 | 6 replies |
Reviews trailers per patch
All 2 patches have a Reviewed-by or Acked-by.
| Patch | Mark Tinguely |
|---|---|
| 1/2 | R-b |
| 2/2 | R-b |
Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes.
Cover letter [PATCH 0/2] xfs: prevent transient corrupt states during log recovery
Hi folks,
The following two patches prvent log recovery from recovering old changes over a newer object on disk, preventing transient corrupt states in memory causing verifier failures when recovery tries to write the objects back to disk.
This only works for v5 filesystems as it relies on the LSN that is contained in all v5 metadata and stamped with the current LSN when ever the metadata is written to doisk.
The first patch fixes a problem with LSN fields being unitialised and logged in that state, and then having recovery restore that uninitialised state and confuse any further attempts by recovery to determine the age of the object by LSN.
The second patch does the work of determining the age of an object being recovered based on the magic number in the object. The reasons for doing this are described in that patch.
By skipping recovery of objects that are newer on disk than in the checkpoint being recovered, we ensure that log recovery never creates a transient corrupt state during recovery in memory, and hence we never attempt to write them to disk and so recovery won't abort due to corruption being detected due to this issue.
Cheers,
Dave.
_______________________________________________
xfs mailing list
[email protected]
http://oss.sgi.com/mailman/listinfo/xfs