Skip to content

SCSI: esas2r: Static check fixes

Bradley Grove linux-scsi 2 versions – New

Get series with b4
b4 am [email protected]

Versions newest first · linked by author and title

  1. v2 Latest7 patches 0 repliesNew
  2. v16 patches 1 replySuperseded

Patches in v2 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/7SCSI: esas2r: smatch - Use biwise rather than logical AND for checking if any bit setdrivers/scsi/esas2r/esas2r_init.c+1 -10 replies
2/7SCSI: esas2r: smatch - Fix dereference that occurs prior to checkdrivers/scsi/esas2r/esas2r_init.c+2 -10 replies
3/7SCSI: esas2r: smatch - Fix dereference that occurs prior to checkdrivers/scsi/esas2r/esas2r_flash.c+6 -10 replies
4/7SCSI: esas2r: smatch - Fix overrun due to sprintf appending NULLdrivers/scsi/esas2r/esas2r_vda.c+5 -20 replies
5/7SCSI: esas2r: smatch - Remove test for impossible condition (uint8 > 255)drivers/scsi/esas2r/esas2r_ioctl.c+1 -10 replies
6/7SCSI: esas2r: coccinelle - Replace memcpy with struct assignmentdrivers/scsi/esas2r/esas2r_flash.c+2 -20 replies
7/7SCSI: esas2r: Remove null test for stack allocated fw_coredump_bufferdrivers/scsi/esas2r/esas2r_init.c+1 -20 replies

Reviews trailers per patch

No Reviewed-by, Acked-by or Tested-by trailers for v2 yet.

Read the v2 thread

Cover letter [PATCH V2 0/7] SCSI: esas2r: Static check fixes

This series of patches fixes errors detected by smatch and coccinelle.

V2 adds an additional fix, removing a null check on a stack allocated array. The test was needed in older versions of the driver when the buffer was allocated on the heap.

Bradley Grove (7):
SCSI: esas2r: smatch - Use biwise rather than logical AND for checking
if any bit set
SCSI: esas2r: smatch - Fix dereference that occurs prior to check
SCSI: esas2r: smatch - Fix dereference that occurs prior to check
SCSI: esas2r: smatch - Fix overrun due to sprintf appending NULL
SCSI: esas2r: smatch - Remove test for impossible condition (uint8 >

    255)

SCSI: esas2r: coccinelle - Replace memcpy with struct assignment
SCSI: esas2r: Remove null test for stack allocated fw_coredump_buffer

 drivers/scsi/esas2r/esas2r_flash.c | 11 ++++++++---
 drivers/scsi/esas2r/esas2r_init.c  |  8 ++++----
 drivers/scsi/esas2r/esas2r_ioctl.c |  2 +-
 drivers/scsi/esas2r/esas2r_vda.c   |  7 +++++--
 4 files changed, 18 insertions(+), 10 deletions(-)
Signature · 1 line
1.8.1.4