Skip to content

RFC Introduce console for ringbuf backend

Lei Li qemu-devel 1 version In review

Get series with b4
b4 am [email protected]

Versions newest first

  1. v1 RFC Latest4 patches 3 repliesIn review

Patches in v1 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/4monitor: introduce monitor_read_consoleinclude/monitor/monitor.h monitor.c+17 -01 reply
2/4hmp: factor out ringbuf_print_help()hmp.c+19 -121 reply
3/4qemu-char: export ringbuf_countinclude/sysemu/char.h qemu-char.c+3 -10 replies
4/4hmp: add console support for ringbuf backendhmp-commands.hx hmp.c hmp.h+132 -01 reply

Reviews trailers per patch

No Reviewed-by, Acked-by or Tested-by trailers for v1 yet.

Read the v1 thread

Cover letter [Qemu-devel] [PATCH 0/4 RFC] Introduce console for ringbuf backend

This patch series aims at adding HMP console feature for ringbuf backend. It behaves like a serial console, which drops user into an interactive mode with ringbuf backend and takes user back to the monitor by the 'ctrl-]' escape sequence.

It would suspend the monitor, output the data that backed in the ringbuf backend to console first, and install a new readline handler to get input from console back into the ringbuf backend. Once escape sequence is detected, it will resume the monitor.

This implementation is reworked based on Anthony's suggestions on the previous version:

http://lists.gnu.org/archive/html/qemu-devel/2013-01/msg03888.html

Suggestions and comments are very welcome!

Lei Li (4):
monitor: introduce monitor_read_console
hmp: factor out ringbuf_print_help()
qemu-char: export ringbuf_count
hmp: add console support for ringbuf backend

 hmp-commands.hx           |   21 +++++++
 hmp.c                     |  141 +++++++++++++++++++++++++++++++++++++++++----
 hmp.h                     |    1 +
 include/monitor/monitor.h |    3 +
 include/sysemu/char.h     |    2 +
 monitor.c                 |   14 +++++
 qemu-char.c               |    2 +-
 7 files changed, 171 insertions(+), 13 deletions(-)