Skip to content

bonding: locking simplifications and cleanup

Nikolay Aleksandrov netdev 1 version In review

Get series with b4
b4 am [email protected]

Versions newest first

  1. v1 Latest5 patches 2 repliesIn review

Patches in v1 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/5bonding: simplify and fix peer notificationdrivers/net/bonding/bond_main.c+7 -150 replies
2/5bonding: trivial: remove outdated comment and bracesdrivers/net/bonding/bond_main.c+1 -50 replies
3/5bonding: simplify bond_3ad_update_lacp_rate and use RTNL for syncdrivers/net/bonding/bond_3ad.c drivers/net/bonding/bond_sysfs.c+7 -80 replies
4/5bonding: drop read_lock in bond_fix_featuresdrivers/net/bonding/bond_main.c+3 -70 replies
5/5bonding: drop read_lock in bond_compute_featuresdrivers/net/bonding/bond_main.c+3 -70 replies

Reviews trailers per patch

None of the 5 patches has a Reviewed-by or Acked-by of their own; the series has one for all of them.

PatchDing Tianhong
SeriesR-b
1/5
2/5
3/5
4/5
5/5

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes.

Read the v1 thread

Cover letter [PATCH net-next 0/5] bonding: locking simplifications and cleanup

Hello,
This small patchset aims to remove some use cases of bond->lock for mutual exclusion which will help in the RCUfication of the function users. It also does some small style cleanups and fixes.

Patch 01 - Drops the use of bond->lock as mutual exclusion for peer notification and relies on RTNL being held when send_peer_notif is modified Patch 02 - trivial outdated comment removal
Patch 03 - Drops the use of bond->lock as mutual exclusion for lacp rate update and relies on RTNL, also fixes possible races with mode change Patch 04 - Drops read_lock in bond_fix_features because RTNL is held Patch 05 - Drops read_lock in bond_compute_features because RTNL is held whenever it's called

Best regards,
Nikolay Aleksandrov

Nikolay Aleksandrov (5):
bonding: simplify and fix peer notification
bonding: trivial: remove outdated comment and braces
bonding: simplify bond_3ad_update_lacp_rate and use RTNL for sync
bonding: drop read_lock in bond_fix_features
bonding: drop read_lock in bond_compute_features

 drivers/net/bonding/bond_3ad.c   |  8 +------
 drivers/net/bonding/bond_main.c  | 48 ++++++++++++----------------------------
 drivers/net/bonding/bond_sysfs.c |  7 +++++-
 3 files changed, 21 insertions(+), 42 deletions(-)
Signature · 1 line
1.8.1.4