Skip to content

Make dwc3 use Generic PHY Framework

Kishon Vijay Abraham I linux-arm-kernel linux-devicetree linux-omap lkml 4 versions – In review

Get series with b4
b4 am [email protected]

Versions newest first · linked by author and title

  1. v5 Latest6 patches 10 repliesIn review
  2. v310 patches 10 repliesSuperseded
  3. v27 patches 24 repliesSuperseded
Earlier versions · 1
VersionPostedPatchesRepliesStatus
v17 patches39 repliesSuperseded

Changes from v2 from the cover letter

* added a couple of fixes. One is invoking phy_resume after phy_init and the other is power off phy in error patch
* used quirks to identify if a particular platform does not have PHYs
* removed using separate header for pipe3 driver and also removed all referencs to SATA and PCIe in pipe3 driver since it's not yet adapted for those drivers.

Patches in v5 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/6usb: dwc3: core: support optional PHYsdrivers/usb/dwc3/core.c+14 -200 replies
2/6usb: dwc3: adapt dwc3 core to use Generic PHY FrameworkDocumentation/devicetree/bindings/usb/dwc3.txt drivers/usb/dwc3/core.c drivers/usb/dwc3/core.h+89 -103 replies
3/6drivers: phy: usb3/pipe3: Adapt pipe3 driver to Generic PHY Frameworkdrivers/phy/Kconfig drivers/phy/Makefile drivers/phy/phy-ti-pipe3.c +2 more+158 -1061 reply
4/6usb: phy: omap-usb2: remove *set_suspend* callback from omap-usb2drivers/phy/phy-omap-usb2.c+0 -250 replies
5/6phy: omap-usb2: move omap_usb.h from linux/usb/ to linux/phy/drivers/phy/phy-omap-usb2.c include/linux/phy/omap_usb.h+1 -40 replies
6/6arm/dts: added dt properties to adapt to the new phy framworkarch/arm/boot/dts/omap5.dtsi+4 -12 replies

Reviews trailers per patch

2 of 6 patches have a Reviewed-by or Acked-by.

PatchRoger QuadrosFelipe BalbiSylwester Nawrocki
1/6R-b
2/6
3/6
4/6A-b R-b
5/6
6/6

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes. Scroll the table sideways for all 3 reviewers.

Read the v5 thread

Cover letter [PATCH v5 0/6] Make dwc3 use Generic PHY Framework

Added support for optional PHY in dwc3 as not all SoCs having PHYs for DWC3 should be programmed. While this can be considered as a temporary fix, a long term solution would be to add 'nop' PHY for platforms that does not have programmable PHY.
Adapted DWC3 and USB3 PHY to use Generic PHY framework. Also changed the name of USB3 PHY driver to PIPE3 PHY driver since the same driver has to be used for SATA and PCIE too.

Changes from v4: (sending the entire patch series again)
* check the return values of phy_init and phy_power_on
* print errors if power_on or power_off of PHY fails.

Changes from v3: (Sent only adapt dwc3 core to use Generic PHY Framework)
* avoided using quirks and rely on the return values of PHY APIs to find the presence of PHY.

Changes from v2:
* added a couple of fixes. One is invoking phy_resume after phy_init and the other is power off phy in error patch
* used quirks to identify if a particular platform does not have PHYs
* removed using separate header for pipe3 driver and also removed all referencs to SATA and PCIe in pipe3 driver since it's not yet adapted for those drivers.

Changes from v1:
* The logic in which the driver detects the presence of PHYs has changed.
* patch ordering has changed
* udelay is replaced with usleep_range
* A patch to remove set_suspend callback which was deferred from Generic PHY Framework series has been included.

Kishon Vijay Abraham I (6):
usb: dwc3: core: support optional PHYs
usb: dwc3: adapt dwc3 core to use Generic PHY Framework
drivers: phy: usb3/pipe3: Adapt pipe3 driver to Generic PHY Framework
usb: phy: omap-usb2: remove *set_suspend* callback from omap-usb2
phy: omap-usb2: move omap_usb.h from linux/usb/ to linux/phy/ arm/dts: added dt properties to adapt to the new phy framwork

 Documentation/devicetree/bindings/usb/dwc3.txt     |    6 +-
 arch/arm/boot/dts/omap5.dtsi                       |    5 +-
 drivers/phy/Kconfig                                |   11 +
 drivers/phy/Makefile                               |    1 +
 drivers/phy/phy-omap-usb2.c                        |   27 +--
 .../phy/phy-omap-usb3.c => phy/phy-ti-pipe3.c}     |  240 ++++++++++++--------
 drivers/usb/dwc3/core.c                            |  116 +++++++---
 drivers/usb/dwc3/core.h                            |    7 +
 drivers/usb/phy/Kconfig                            |   11 -
 drivers/usb/phy/Makefile                           |    1 -
 include/linux/{usb => phy}/omap_usb.h              |    3 -
 11 files changed, 264 insertions(+), 164 deletions(-)
 rename drivers/{usb/phy/phy-omap-usb3.c => phy/phy-ti-pipe3.c} (54%)
 rename include/linux/{usb => phy}/omap_usb.h (95%)
Signature · 1 line
1.7.9.5